-
Notifications
You must be signed in to change notification settings - Fork 62
Bug 169 : Operation path encoding as required by RFC6901 #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The travis build with openjdk11 failed on https://travis-ci.org/eclipse-ee4j/jsonp/jobs/524021578 Build successfully in local with openjdk 11.0.2 and 1.8.0_202. I don't understand the travis build failed on 11.0.2.. |
Hello @dylanbehetre |
It looks good to me, but I want to hear @lukasj opinion before merging it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update copyright years in all files you changed.
Signed-off-by: dbehetre <[email protected]>
I change the date on the right to 2019, is it ok for you ? |
@dylanbehetre yes |
@keilw it’s in the queue. Or is this the only issue blocking Jakarta EE 8 work? Are we going to restage the release if this gets merged immediately? |
I already did changes asking in requested changes on 22 July. I don't understand why the requested changes are always here. |
What's the status here? Jakarta EE 8 is done, so it won't be until another update to Jakarta JSONP |
Hi every one, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
To fix the issue 169 referenced at https://github.com/eclipse-ee4j/jsonp/issues/169, this commit change the method diffObject in JsonPatchImpl.java:224.
Before to add the key in operation patch, this code encode it as required by RFC6901 - JsonPointer.
Signed-off-by: dbehetre [email protected]