Skip to content

Bug 169 : Operation path encoding as required by RFC6901 #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2019

Conversation

dylanbehetre
Copy link

To fix the issue 169 referenced at https://github.com/eclipse-ee4j/jsonp/issues/169, this commit change the method diffObject in JsonPatchImpl.java:224.

Before to add the key in operation patch, this code encode it as required by RFC6901 - JsonPointer.

Signed-off-by: dbehetre [email protected]

@dylanbehetre
Copy link
Author

dylanbehetre commented Apr 24, 2019

The travis build with openjdk11 failed on JSR 374 (JSON Processing) API, I wasn't update this part. Any suggestion ?

https://travis-ci.org/eclipse-ee4j/jsonp/jobs/524021578

Build successfully in local with openjdk 11.0.2 and 1.8.0_202. I don't understand the travis build failed on 11.0.2..

@leadpony
Copy link
Contributor

Hello @dylanbehetre
Please see #163

@keilw keilw requested review from asoldano and bshannon July 9, 2019 15:55
@m0mus m0mus requested a review from lukasj July 20, 2019 15:37
@m0mus
Copy link
Contributor

m0mus commented Jul 20, 2019

It looks good to me, but I want to hear @lukasj opinion before merging it.

Copy link
Contributor

@m0mus m0mus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update copyright years in all files you changed.

@dylanbehetre
Copy link
Author

Please update copyright years in all files you changed.

I change the date on the right to 2019, is it ok for you ?

@m0mus
Copy link
Contributor

m0mus commented Jul 23, 2019

@dylanbehetre yes

@keilw
Copy link
Member

keilw commented Aug 8, 2019

@m0mus Is @lukasj on vacation because he has not provided any input here?

@lukasj
Copy link
Contributor

lukasj commented Aug 8, 2019

@keilw it’s in the queue. Or is this the only issue blocking Jakarta EE 8 work? Are we going to restage the release if this gets merged immediately?

@dylanbehetre dylanbehetre requested a review from m0mus October 10, 2019 09:32
@dylanbehetre
Copy link
Author

I already did changes asking in requested changes on 22 July. I don't understand why the requested changes are always here.

@keilw
Copy link
Member

keilw commented Oct 11, 2019

What's the status here? Jakarta EE 8 is done, so it won't be until another update to Jakarta JSONP

@srius
Copy link

srius commented Dec 3, 2019

Hi every one,
Would it be possible to have an update on this PR state ? Change requested seems to be taken into account by Dylan...
Should the PR be adapted to comply to new package name ? What is expected from you ?

Copy link
Contributor

@m0mus m0mus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m0mus m0mus merged commit 7e261a6 into jakartaee:master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants