[ES][v2] Change the DB Tag value from string to any type
#6994
+324
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manik2708 <[email protected]>
Signed-off-by: Manik2708 <[email protected]>
Manik2708
commented
Apr 7, 2025
| @@ -551,6 +551,17 @@ func TestFromDbModel_Fixtures(t *testing.T) { | |||
| testTraces(t, tracesData, actualTd) | |||
| } | |||
|
|
|||
| func TestFromDBModel_StringTags_Fixtures(t *testing.T) { | |||
There was a problem hiding this comment.
This is for backward compatibility
yurishkuro
reviewed
Apr 7, 2025
yurishkuro
reviewed
Apr 7, 2025
yurishkuro
reviewed
Apr 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6994 +/- ##
==========================================
- Coverage 95.99% 95.97% -0.02%
==========================================
Files 346 346
Lines 20429 20468 +39
==========================================
+ Hits 19611 19645 +34
- Misses 616 620 +4
- Partials 202 203 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Manik2708 <[email protected]>
4 tasks
|
/Don't Merge Firstly let the #6998 get merged, there are some changes which will be required in this PR after analaysing the integration tests! |
Signed-off-by: Manik2708 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes a part of: #6458
Description of the changes
tagDotReplacementinToDBModel#6946 we need to change the value which was saved as string in v1 to a raw value in v2How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test