-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move pkg/jtracer to internal/jtracer #6906
base: main
Are you sure you want to change the base?
Move pkg/jtracer to internal/jtracer #6906
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project check has failed because the head coverage (50.55%) is below the target coverage (95.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## main #6906 +/- ##
===========================================
- Coverage 96.26% 50.55% -45.72%
===========================================
Files 343 178 -165
Lines 20313 10482 -9831
===========================================
- Hits 19554 5299 -14255
- Misses 574 4788 +4214
- Partials 185 395 +210
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does not lint
c406984
to
814609b
Compare
needs |
Signed-off-by: sAchin-680 <[email protected]>
…al directory and adding new context and test files Signed-off-by: sAchin-680 <[email protected]>
814609b
to
89ddf1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- title doesn't match content
- please move into collector next to http.go (e.g. httpmetrics.go)
Got it! I'll update the title to better reflect the content and move it into the collector next to |
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:npm run lint
andnpm run test