Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pkg/jtracer to internal/jtracer #6906

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sAchin-680
Copy link
Contributor

@sAchin-680 sAchin-680 commented Mar 22, 2025

Which problem is this PR solving?

Description of the changes

  • Move pkg/jtracer/ to internal/jtracer/
  • Updated all imports referencing pkg/jtracer/ to internal/jtracer/

How was this change tested?

Checklist

@sAchin-680 sAchin-680 requested a review from a team as a code owner March 22, 2025 14:32
@sAchin-680 sAchin-680 requested a review from pavolloffay March 22, 2025 14:32
Copy link

codecov bot commented Mar 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.55%. Comparing base (26bfb4f) to head (c8f2a34).

❌ Your project check has failed because the head coverage (50.55%) is below the target coverage (95.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (26bfb4f) and HEAD (c8f2a34). Click for more details.

HEAD has 23 uploads less than BASE
Flag BASE (26bfb4f) HEAD (c8f2a34)
badger_v1 2 1
grpc_v1 2 1
kafka-3.x-v1 2 1
badger_v2 2 1
memory_v2 2 1
grpc_v2 2 1
tailsampling-processor 2 1
kafka-3.x-v2 2 1
elasticsearch-6.x-v1 2 1
elasticsearch-7.x-v1 2 1
cassandra-4.x-v1-manual 2 1
cassandra-5.x-v1-manual 2 1
opensearch-1.x-v1 2 1
opensearch-2.x-v1 2 1
unittests 2 0
elasticsearch-8.x-v1 2 1
elasticsearch-8.x-v2 2 1
opensearch-2.x-v2 2 1
cassandra-4.x-v2-auto 2 1
cassandra-5.x-v2-auto 2 1
cassandra-5.x-v2-manual 2 1
cassandra-4.x-v2-manual 2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6906       +/-   ##
===========================================
- Coverage   96.26%   50.55%   -45.72%     
===========================================
  Files         343      178      -165     
  Lines       20313    10482     -9831     
===========================================
- Hits        19554     5299    -14255     
- Misses        574     4788     +4214     
- Partials      185      395      +210     
Flag Coverage Δ
badger_v1 10.21% <ø> (ø)
badger_v2 2.12% <ø> (ø)
cassandra-4.x-v1-manual 15.36% <ø> (ø)
cassandra-4.x-v2-auto 2.11% <ø> (ø)
cassandra-4.x-v2-manual 2.11% <ø> (ø)
cassandra-5.x-v1-manual 15.36% <ø> (ø)
cassandra-5.x-v2-auto 2.11% <ø> (ø)
cassandra-5.x-v2-manual 2.11% <ø> (ø)
elasticsearch-6.x-v1 20.12% <ø> (ø)
elasticsearch-7.x-v1 20.21% <ø> (ø)
elasticsearch-8.x-v1 20.38% <ø> (-0.06%) ⬇️
elasticsearch-8.x-v2 2.12% <ø> (ø)
grpc_v1 11.28% <ø> (ø)
grpc_v2 8.23% <ø> (ø)
kafka-3.x-v1 10.51% <ø> (ø)
kafka-3.x-v2 2.12% <ø> (ø)
memory_v2 2.12% <ø> (ø)
opensearch-1.x-v1 20.26% <ø> (ø)
opensearch-2.x-v1 20.26% <ø> (-0.06%) ⬇️
opensearch-2.x-v2 2.12% <ø> (ø)
tailsampling-processor 0.57% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not lint

@sAchin-680 sAchin-680 force-pushed the move-jtracer-to-internal branch 4 times, most recently from c406984 to 814609b Compare March 24, 2025 12:26
@yurishkuro
Copy link
Member

needs make fmt

@sAchin-680 sAchin-680 force-pushed the move-jtracer-to-internal branch from 814609b to 89ddf1e Compare March 24, 2025 14:24
@sAchin-680 sAchin-680 requested a review from yurishkuro March 24, 2025 14:46
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • title doesn't match content
  • please move into collector next to http.go (e.g. httpmetrics.go)

@sAchin-680
Copy link
Contributor Author

Got it! I'll update the title to better reflect the content and move it into the collector next to http.go as httpmetrics.go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants