Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added alerts for jaeger 2.x #6854

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

danish9039
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • add alerts for jaeger 2.x

How was this change tested?

Checklist

@danish9039 danish9039 requested a review from a team as a code owner March 15, 2025 18:03
@danish9039 danish9039 requested a review from mahadzaryab1 March 15, 2025 18:03
@dosubot dosubot bot added the v2 label Mar 15, 2025
@danish9039 danish9039 changed the title Prom added alerts for jaeger 2.x Mar 15, 2025
Copy link

codecov bot commented Mar 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.04%. Comparing base (712c1bc) to head (478f0aa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6854      +/-   ##
==========================================
+ Coverage   96.03%   96.04%   +0.01%     
==========================================
  Files         367      367              
  Lines       20831    20831              
==========================================
+ Hits        20005    20008       +3     
+ Misses        630      628       -2     
+ Partials      196      195       -1     
Flag Coverage Δ
badger_v1 9.88% <ø> (ø)
badger_v2 2.05% <ø> (ø)
cassandra-4.x-v1-manual 14.87% <ø> (ø)
cassandra-4.x-v2-auto 2.04% <ø> (ø)
cassandra-4.x-v2-manual 2.04% <ø> (ø)
cassandra-5.x-v1-manual 14.87% <ø> (ø)
cassandra-5.x-v2-auto 2.04% <ø> (ø)
cassandra-5.x-v2-manual 2.04% <ø> (ø)
elasticsearch-6.x-v1 19.55% <ø> (ø)
elasticsearch-7.x-v1 19.62% <ø> (ø)
elasticsearch-8.x-v1 19.79% <ø> (ø)
elasticsearch-8.x-v2 2.05% <ø> (ø)
grpc_v1 10.92% <ø> (ø)
grpc_v2 7.98% <ø> (ø)
kafka-3.x-v1 10.18% <ø> (ø)
kafka-3.x-v2 2.05% <ø> (ø)
memory_v2 2.05% <ø> (ø)
opensearch-1.x-v1 19.67% <ø> (ø)
opensearch-2.x-v1 19.67% <ø> (ø)
opensearch-2.x-v2 2.05% <ø> (ø)
tailsampling-processor 0.55% <ø> (ø)
unittests 94.92% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danish9039 danish9039 force-pushed the prom branch 4 times, most recently from 3a7d679 to c248ed9 Compare March 15, 2025 18:57
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can this be tested / validated?

@danish9039
Copy link
Contributor Author

danish9039 commented Mar 17, 2025

how can this be tested / validated?

i have tested this in my local machine by setting up jaeger v2 and opentelemetry collector and scrap it using prometheus , while runing a testing application for producing matrices and simulating scenarios , at first i investigated available metrices by curl http://127.0.0.1:8888/metrics , then i checked the all rules are visible in prometheus ui , then i created different scenarios and checked if the alerts where firing

@yurishkuro
Copy link
Member

Thanks. It's good that you did manual testing, but as soon as some metric changes this file becomes invalid. How can it be tested automatically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants