-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added alerts for jaeger 2.x #6854
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6854 +/- ##
==========================================
+ Coverage 96.03% 96.04% +0.01%
==========================================
Files 367 367
Lines 20831 20831
==========================================
+ Hits 20005 20008 +3
+ Misses 630 628 -2
+ Partials 196 195 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3a7d679
to
c248ed9
Compare
Signed-off-by: danish9039 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how can this be tested / validated?
i have tested this in my local machine by setting up jaeger v2 and opentelemetry collector and scrap it using prometheus , while runing a testing application for producing matrices and simulating scenarios , at first i investigated available metrices by curl http://127.0.0.1:8888/metrics , then i checked the all rules are visible in prometheus ui , then i created different scenarios and checked if the alerts where firing |
Thanks. It's good that you did manual testing, but as soon as some metric changes this file becomes invalid. How can it be tested automatically? |
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:npm run lint
andnpm run test