ES v1 tests take too long

[yurishkuro]

$ go test -race ./internal/storage/v1/elasticsearch/
ok  	github.com/jaegertracing/jaeger/internal/storage/v1/elasticsearch	11.506s

Running with profiler

$ GOMAXPROCS=1 go test -parallel 128 -p 16 -json ./internal/storage/v1/elasticsearch/ | go run github.com/roblaszczak/vgt@latest

shows 3 tests blocking for 5 seconds each

[rishi-jat]

 Hi, I'd like to work on this issue as part of my contribution. Could you please assign it to me if it's still available?

[yurishkuro]

we don't assign issues, feel free to submit a PR

[rishi-jat]

Thanks! I’ll start working on it and will open a PR soon.

[danish9039]

for https://github.com/jaegertracing/jaeger/blob/bafa50774a2b4d687642fa26875f1308a15c9cb8/internal/storage/v1/elasticsearch/factory_test.go#L277C1-L364C1 we can Reduce the timeout values in the assert.Eventually calls . Since these are unit tests using an in-memory HTTP test server, they should complete much faster .

https://github.com/jaegertracing/jaeger/blob/bafa50774a2b4d687642fa26875f1308a15c9cb8/internal/storage/v1/elasticsearch/factory_test.go#L250C1-L259C2 and https://github.com/jaegertracing/jaeger/blob/bafa50774a2b4d687642fa26875f1308a15c9cb8/internal/storage/v1/elasticsearch/factoryv1_test.go#L104C1-L127C2 tests are taking approx 5 seconds each primarily due to timeouts occurring when these tests attempted to connect to a non-existent Elasticsearch server in test cases . The Elasticsearch client library has a default health check timeout of 5 seconds that is causing the extra time . instead of checking the real network calls for es server we can mock the error to eliminate the timeout , is it correct ?? @yurishkuro

[yurishkuro]

the test is meant to test error handling when not able to connect to the db server. It may be possible to mock something underneath the HTTP client (like roundtripper) to return an error immediately.

[sonalgaud12]

Hi @danish9039, are you working on this pr? . If not please do let me know

[danish9039]

Hi @danish9039, are you working on this pr? . If not please do let me know

Yes I am working on this

[blazethunderstorm]

@yurishkuro can i work on this pls