Skip to content

Migrate HopsSelector tests #2746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 2, 2025
Merged

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Apr 30, 2025

Which problem is this PR solving?

Description of the changes

  • Migrates HopsSelector test

How was this change tested?

  • Test itself.

Checklist

@nojaf nojaf force-pushed the enzyme/HopsSelector branch from 7e70e04 to 406b973 Compare April 30, 2025 09:30
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.85%. Comparing base (86d90c6) to head (406b973).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2746   +/-   ##
=======================================
  Coverage   96.85%   96.85%           
=======================================
  Files         256      256           
  Lines        7945     7951    +6     
  Branches     2069     2075    +6     
=======================================
+ Hits         7695     7701    +6     
  Misses        250      250           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nojaf nojaf marked this pull request as ready for review April 30, 2025 09:33
@nojaf nojaf requested a review from a team as a code owner April 30, 2025 09:33
@nojaf nojaf requested review from joe-elliott and removed request for a team April 30, 2025 09:33
@yurishkuro yurishkuro added the changelog:test Change that's adding missing tests or correcting existing tests label May 2, 2025
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@yurishkuro yurishkuro added this pull request to the merge queue May 2, 2025
Merged via the queue into jaegertracing:main with commit ad84ea6 May 2, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:test Change that's adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants