Skip to content

Add ability to use typescript in tests #2731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 3, 2025

Conversation

DamianMaslanka5
Copy link
Contributor

Which problem is this PR solving?

Better DX, Find References in VS Code doesn't work correctly when functions are used in test.js files

Description of the changes

Allow using TS in tests

Docs which describe how to setup jest with TS https://jestjs.io/docs/getting-started#type-definitions

TS integrates better with VS Code.
For example, using Find References on functions from tsx files
doesn't find references in test.js files.

Signed-off-by: Damian Maslanka <[email protected]>
@DamianMaslanka5 DamianMaslanka5 requested a review from a team as a code owner April 28, 2025 19:05
@DamianMaslanka5 DamianMaslanka5 requested review from jkowall and removed request for a team April 28, 2025 19:05
@DamianMaslanka5 DamianMaslanka5 changed the title Ts tests Add ability to use typescript in tests Apr 28, 2025
Copy link

codecov bot commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.86%. Comparing base (01c42e0) to head (a558ea4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2731   +/-   ##
=======================================
  Coverage   96.86%   96.86%           
=======================================
  Files         256      256           
  Lines        7951     7951           
  Branches     2076     2001   -75     
=======================================
  Hits         7702     7702           
- Misses        248      249    +1     
+ Partials        1        0    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This package is required for types to work correctly in .test.ts files

Signed-off-by: Damian Maslanka <[email protected]>
@yurishkuro yurishkuro added changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements changelog:ci Change related to continuous integration / testing and removed changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements labels Apr 28, 2025
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
yurishkuro previously approved these changes May 3, 2025
This reverts commit ce9dd1a.

Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro added this pull request to the merge queue May 3, 2025
Merged via the queue into jaegertracing:main with commit 2683d98 May 3, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants