Prototype detecting fullscreen apps to override brightness #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
commented
Feb 3, 2025
| @@ -116,7 +143,10 @@ unsafe extern "system" fn wndproc( | |||
| wparam: WPARAM, | |||
| lparam: LPARAM, | |||
| ) -> LRESULT { | |||
| if let Some(window_data) = window.get_user_data::<WindowData>() { | |||
| let window_data_ptr = GLOBAL_WINDOW_DATA.load(Ordering::SeqCst); | |||
There was a problem hiding this comment.
I had to change this because the win_event_hook_proc I added doesn't have a handle to our window.
xPaw
force-pushed
the
fullscreen
branch
2 times, most recently
from
c7fbb86 to
0324814
Compare
xPaw
commented
Feb 4, 2025
|
|
||
| let window_data = &mut *window_data_ptr; | ||
|
|
||
| // TODO: This is likely to be buggy on multi monitor setups when both monitors have fullscreen apps open |
There was a problem hiding this comment.
this is a tricky case to handle, but having one global bool for fullscreen is wrong, as it's possible to get it stuck in wrong case when switching from fullscreen app on one monitor, to non-fullscreen app on another.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #47.
I prototyped the code to detect fullscreen foreground windows on Windows systems.
This appears to work on my machine with two screens, whenever switching to an app that is fullscreened on either screen. When switching to another non-fullscreen window, it drops brightness.
I'm calling this a prototype, because it currently just calls "pause" which forces day brightness on all monitors, but for this feature I'd want it to only change brightness of the monitor that has the fullscreen window. It probably also needs a setting for users to disable this feature, and maybe set custom brightness.
For only changing brightness of one screen, I am unsure how to implement this well. One day I had in mind is just get the device id/path and create an override similar to how you can do that in GUI.