Skip to content

Folder and file of same name panics with internal error #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
christopher-buss opened this issue Jun 23, 2024 · 2 comments · Fixed by #97 or #98
Closed

Folder and file of same name panics with internal error #67

christopher-buss opened this issue Jun 23, 2024 · 2 comments · Fixed by #97 or #98
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@christopher-buss
Copy link

Obviously it can't work to have a file and a folder of the same name, but I get an error internal error: entered unreachable code, rather than a more helpful error message.

@christopher-buss christopher-buss changed the title Folder with file and image of same name throws error. Folder with folder and file of same name throws error. Jun 23, 2024
@christopher-buss christopher-buss changed the title Folder with folder and file of same name throws error. Folder and file of same name throws error. Jun 23, 2024
@jackTabsCode jackTabsCode added the question Further information is requested label Jun 23, 2024
@jackTabsCode
Copy link
Owner

@christopher-buss Can you give me more information? Your asphalt.toml file, a screenshot of your assets folder fully expanded, and the full error given by Asphalt? I'm lost.

@christopher-buss
Copy link
Author

A minimal reproduction can be seen here.
image
image

We can't generate files with the same name as another in the same directory, which makes perfect sense as the codegen can't create two entries for the same name, but asphalt errors rather than giving the user a nice error code letting them know what is going on.

@jackTabsCode jackTabsCode added bug Something isn't working good first issue Good for newcomers and removed question Further information is requested labels Jun 25, 2024
@jackTabsCode jackTabsCode changed the title Folder and file of same name throws error. Folder and file of same name panics with internal error Jun 25, 2024
@jackTabsCode jackTabsCode mentioned this issue Mar 25, 2025
13 tasks
@jackTabsCode jackTabsCode mentioned this issue Mar 26, 2025
13 tasks
jackTabsCode added a commit that referenced this issue Mar 26, 2025
Closes #87 
Closes #84 
Closes #67 

- [x] walk
- [x] process
- [x] sync
  - [x] cloud
  - [x] studio
  - [x] debug
- [x] existing assets support 
- [x] codegen
- [x] upload
- [x] upload command
- [x] migrate from old asphalt lockfile command
  - need to consider inputs
- [x] update readme
- [x] Test on Windows to see if I messed up any path stuff

Deferred until final release
- migrate tarmac manifest command
- init command

Deferred to the next update:
- image packing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants