Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cylinder to New Geometry options #576

Merged
merged 2 commits into from
Mar 5, 2024

fix cylinder creation

8890c8b
Select commit
Loading
Failed to load commit list.
Merged

add cylinder to New Geometry options #576

fix cylinder creation
8890c8b
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Mar 4, 2024 in 0s

5 new issues (0 max.) of at least medium severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 11
- Added 20
           

Complexity increasing per file
==============================
- jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java  1
- jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/actions/impl/NewGeometryCylinderAction.java  1
- jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/actions/impl/NewGeometryQuadAction.java  1
         

Clones added
============
- jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java  4
- jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateQuadPanel.java  1
         

See the complete overview on Codacy

Annotations

Check notice on line 87 in jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java#L87

Unnecessary use of fully qualified name 'com.jme3.gde.core.sceneexplorer.nodes.actions.impl.AbstractNewGeometryPanel' due to existing import 'com.jme3.gde.core.sceneexplorer.nodes.actions.impl.AbstractNewGeometryPanel'

Check notice on line 213 in jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java#L213

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 213 in jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java#L213

Unnecessary use of fully qualified name 'com.jme3.gde.core.sceneexplorer.nodes.actions.impl.AbstractNewGeometryPanel' due to existing import 'com.jme3.gde.core.sceneexplorer.nodes.actions.impl.AbstractNewGeometryPanel'

Check notice on line 214 in jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java#L214

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 215 in jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java#L215

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 216 in jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java#L216

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check warning on line 216 in jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java#L216

Perhaps 'jPanel1' could be replaced by a local variable.

Check notice on line 217 in jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java#L217

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check warning on line 217 in jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java#L217

Perhaps 'lblHeight' could be replaced by a local variable.

Check notice on line 218 in jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java#L218

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check warning on line 218 in jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java#L218

Perhaps 'lblRadialSamples' could be replaced by a local variable.

Check notice on line 219 in jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java#L219

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check warning on line 219 in jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java#L219

Perhaps 'lblRadius' could be replaced by a local variable.

Check notice on line 220 in jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java#L220

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check warning on line 220 in jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java#L220

Perhaps 'lblZSamples' could be replaced by a local variable.

Check notice on line 221 in jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java#L221

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 222 in jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java#L222

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 223 in jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java#L223

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 224 in jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateCylinderPanel.java#L224

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 169 in jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateQuadPanel.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/primitives/CreateQuadPanel.java#L169

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.