Do not overwrite Editor Profile on every load #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #457
In order to get FlatLaf Dark to work "first time" without needing an IDE reset to fix the colours of the Option header bar etc. I had to move setting the default LaF from the static initialisation block to the
validate()lifecycle hook.Setting the Editor profile doesn't work in the
validate()block though (too early in IDE startup), so I moved it to therestored()lifecycle hook which gets called later - completely missing that it was no longer behind anifso Editor profile was getting set to Dark Monkey colours every time the IDE started.This fixes that by setting a static boolean so that we only set the Editor profile if we are also setting the default LaF (i.e. the first time we load the darkmonkey module).