Improve ProjectAssetManager's Gradle support #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Spotted a couple of typos. Will push a quick update tomorrow |
|
Tested: |
neph1
reviewed
Jan 14, 2023
jme3-core/src/com/jme3/gde/core/assets/ProjectAssetManager.java
Outdated
Show resolved
Hide resolved
neph1
approved these changes
Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully goes some way to fixing #373
A couple of bits that could use further refinement:
When you first create a new Gradle JME project, NB will prompt you for a priming build - due to changes in NB's Gradle API in latest version, because our Gradle project is created by unziping a file rather than using NB's Gradle API, it is untrusted at this stage and the priming build doesn't run. This means the user need to run Gradle build again manually before resources will be loaded off the Gradle dependencies - the real fix for this needs to be in the Gradle template.
Hard coded to use look at the
mainsourceset - if user has defined custom sourcesets in theirbuild.gradlethese will get ignoredCould do with some testing, inc. making sure nothing in Ant based projects is now broken...