Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propose to fix #266 by moving installed jar #438

Merged
merged 2 commits into from
Dec 17, 2022

Conversation

neph1
Copy link
Contributor

@neph1 neph1 commented Dec 12, 2022

This is essentially #417
I don't know enough about the installation process to know if it actually fixes the problem, but I noticed that if I used #417 and then moved the lib to the folder it actually points to, it worked.

Fixes #266

@neph1 neph1 requested a review from tonihele December 12, 2022 19:21
@tonihele
Copy link
Contributor

If it works after you do clean and build. Restart IDE and do it again. Then... it is maybe fine? We can also do a test release at some point to see if it worked or not. Some small fixes already accumulated after last release?

@neph1
Copy link
Contributor Author

neph1 commented Dec 12, 2022

It didn't. Needs investigation... I'll keep trying though. Something made it work.

@tonihele
Copy link
Contributor

Yeah, for me it was like that too. Works when you do it. But.... somehow not permanently.

@neph1
Copy link
Contributor Author

neph1 commented Dec 13, 2022

If it bleeds, we can kill it.

@neph1
Copy link
Contributor Author

neph1 commented Dec 13, 2022

So it actually did work, I had just misspelled the path in build.gradle. I don't find it optimal to change it, but I just can't make it work with the "release/libs/" path.

@neph1
Copy link
Contributor Author

neph1 commented Dec 16, 2022

I did a little bit of further testing with the release/libs path, to no avail. I don't understand why this works but not the other. But unless there are objections, I'll probably merge this some time during the weekend.

@tonihele
Copy link
Contributor

If it works, I'm good with it. I suspect anyway if we get the Maven done. This is obsolete. Maybe.

@neph1 neph1 merged commit a920c9c into jMonkeyEngine:master Dec 17, 2022
@tonihele
Copy link
Contributor

Oh, did you by the way test the test project? Doesn't it use the test data as well on some of the tests?

@neph1
Copy link
Contributor Author

neph1 commented Dec 17, 2022

Which project would that be?

@neph1
Copy link
Contributor Author

neph1 commented Dec 17, 2022

Ah, the JmeTests project. No I didn't, and of course it didn't work when I did.

@neph1
Copy link
Contributor Author

neph1 commented Dec 17, 2022

fix here: #440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Showing HDR Environment is broken
2 participants