Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding black outline on icons. removing label from "play" button #420

Merged

Conversation

neph1
Copy link
Contributor

@neph1 neph1 commented Nov 3, 2022

No description provided.

@tonihele
Copy link
Contributor

tonihele commented Nov 3, 2022

Definitely more readable now. I found few icons that didn't scale (waypoint and the light):
image

@tonihele
Copy link
Contributor

tonihele commented Nov 3, 2022

The pause also looks little bit.... restless... looks like it is too big:
image

@neph1
Copy link
Contributor Author

neph1 commented Nov 4, 2022

Looks like the terrain icon and node icon didn't get outlines either. I used "sed" to replace the styles and had to manually fix some of them.

fixed light bulb, waypoint, pause button, terrain
redesigned node icon
@neph1
Copy link
Contributor Author

neph1 commented Nov 4, 2022

image

Redesigned the node icon a bit to make it more distinct. Replaced the waypoint icon with something more suitable.
Light bulb color is corrected, too (after this screenshot).

# Conflicts:
#	jme3-core/src/com/jme3/gde/core/icons/IconList.java
@neph1 neph1 added this to the 3.5 release milestone Nov 5, 2022
@neph1 neph1 merged commit f43b88f into jMonkeyEngine:master Nov 5, 2022
neph1 added a commit to neph1/sdk that referenced this pull request Nov 17, 2022
@neph1 neph1 deleted the outlining_icons_and_play_button_fix branch May 6, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants