Skip to content

Prevent updateShadowCamera from corrupting shadowCam matrix. #2112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

riccardobl
Copy link
Member

Prevent updateShadowCamera from corrupting shadowCam matrix when there isn't any visible shadow caster in scene.
Discovered in #2111

@riccardobl riccardobl merged commit af075f2 into jMonkeyEngine:master Oct 16, 2023
@riccardobl riccardobl added hacktoberfest-accepted PRs that are Hacktoberfest valid (Optional if PR is merged or approved during the month of october) and removed hacktoberfest-accepted PRs that are Hacktoberfest valid (Optional if PR is merged or approved during the month of october) labels Oct 16, 2023
@stephengold stephengold added this to the Future Release milestone Oct 16, 2023
@stephengold
Copy link
Member

Shouldn't the changes to asserts and diagnostics have been a separate PR?

Also, what's the significance of the hacktoberfest labels? (Just curious.)

@riccardobl
Copy link
Member Author

Shouldn't the changes to asserts and diagnostics have been a separate PR?

Well i wouldn't dedicate a PR to this small change that i made just to debug this issue and I merged the pr without squash to keep the commits separated, so it shouldn't cause any issue for the git history or if we need to revert it.

Also, what's the significance of the hacktoberfest labels? (Just curious.)

Two years ago, I assumed the responsibility of moderating Hacktoberfest for our repositories. This year, in order for a pull request to be considered valid for the quota, it must either be approved, merged, or have a specific label applied for a continuous 7-day period. As we are in the second half of October, I've added the label to mark valid pull requests as soon as they are submitted, avoiding the need for rushed approvals in case the submitter is participating.
I added the label to this PR by mistake.

@stephengold
Copy link
Member

I see. Thanks for the answers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants