Lwjgl3 canvas #1868

tonihele · 2022-11-21T18:45:34Z

Would this be acceptable solution for now? If we open another ticket to implement this for real?

This would fix #1192 and also TestAwtPanels. The performance is not great.. not terrible...

I tried getting https://github.com/LWJGLX/lwjgl3-awt to work but didn't get it display anything yet.

The problem with this solution is that it is pretty much software rendering. The rendering is first done to a Framebuffer as it is recommended. But then everything goes bad, we just render it to an image (I guess slightly accelerated but...) for displaying it to the user. And another problem is that it requires support for non power of two textures.

This is basically copy paste from what we already had in the engine, the Offscreen rendering to an AWT panel.

tonihele · 2022-11-21T18:49:17Z

jme3-lwjgl3/src/main/java/com/jme3/system/lwjgl/LwjglWindow.java

@@ -291,6 +289,8 @@ public void invoke(int error, long description) {
            requestWidth = videoMode.width();
            requestHeight = videoMode.height();
        }
+        oldFramebufferHeight = requestHeight;


By assuming that the scaling factor of 1 is correct we avoid extra resize at the start of application, also fixes TestAwtPanels. If you really don't have scaling... AwtContext wasn't build scaling in mind. It throws an exception when framebuffer resize is triggered, and that is how our scaling currently works.

@tonihele please revert oldFramebufferHeight and oldFramebufferWidth initial values back to 0.

See: https://github.com/jMonkeyEngine/jmonkeyengine/pull/1950/files#r1103859250

TestAwtPanels throws an exception

AwtPanelsContext is modified to log an error instead of throwing an exception which should make TestAwtPanels work again.

Please see #1949

riccardobl · 2022-11-22T09:39:32Z

Thank you for the PR.

Would this be acceptable solution for now? If we open another ticket to implement this for real?

Yes, I think this is the least sketchy way to get this to work reliably, other solutions can be implemented as optimization for specific platforms (eg. i see lwjgl3-awt works only on linux systems that use X11).

Also this should probably work well in most systems.

I have 2 questions:

What is the deal with all the changes to Lists?
Is it possible to remove the non-power-of-two requirement by rounding the sizes to the nearest power of two? (it will introduce some cropping, yes, but it should probably be fine i think)

tonihele · 2022-11-22T09:56:50Z

What is the deal with all the changes to Lists?

Is it possible to remove the non-power-of-two requirement by rounding the sizes to the nearest power of two? (it will introduce some cropping, yes, but it should probably be fine i think)

It is just cleanup, aren't we all taught to program with interfaces? :) Well, I intended to actual have the event queues be queues, but I changed my mind as it would achieve nothing. In sense of clarity or performance the same, so then I just left them as cleanups. Irrelevant changes.
Can be done, also in such matter that our Offscreen rendering would also be void of this requirement. Perhaps in such manner that the capability is checked against and a proper strategy is then used.

riccardobl · 2022-11-22T15:10:48Z

It is just cleanup, aren't we all taught to program with interfaces? :) Well, I intended to actual have the event queues be queues, but I changed my mind as it would achieve nothing. In sense of clarity or performance the same, so then I just left them as cleanups. Irrelevant changes.

Ok, i was questioning the use of Deque vs List, but i've seen now that you did that to use poll(). Ok then.

Can be done, also in such matter that our Offscreen rendering would also be void of this requirement. Perhaps in such manner that the capability is checked against and a proper strategy is then used.

Yep, should be easy enough, since we have already a capability registered for that. Do you plan to address it in this PR or would you like to do it at a later time? Non-power-of-two textures should be supported by the vast majority of GPUs anyway, so we could also decide to leave it like that for now.. and just merge this PR

tonihele · 2022-11-22T15:36:35Z

Yep, should be easy enough, since we have already a capability registered for that. Do you plan to address it in this PR or would you like to do it at a later time? Non-power-of-two textures should be supported by the vast majority of GPUs anyway, so we could also decide to leave it like that for now.. and just merge this PR

I would do additional issues. Not this PR. The following issues would be created:

The non-power of two issue is existing issue with the offscreen rendering, create issue for it
Implement HW accelerated Lwjgl3 Canvas

1 & 2 can be handled then separately without applying any pressure on one another. And if 2 is done before, well, that is all good then, canvas works.

Also there are issues about the scaling and canvas. That should be taken into consideration when touching issue number two.

Ali-RS · 2022-12-31T09:34:55Z

What is the state of this PR?
Should this become a candidate for the next release?
Is anybody willing to review and possibly merge it?

tonihele · 2022-12-31T10:07:38Z

What is the state of this PR? Should this become a candidate for the next release? Is anybody willing to review and possibly merge it?

It is ready.

What it is, is a poor solution to something that currently doesn't work at all. With this it works. Usability depends largely on what it is being used for, i.e. gaming, not feasible; using LWJGL 3 and a small 3D canvas in your app, feasibleish. There is the test canvas test app for this.

Even I'm on the fence with this one. My small hope was that we could use LWJGL 3 with the jME SDK with this. But I don't know if this even really makes it possible. SDK rendering at least would need so little power that in that way this would work.

Future development needed as stated above.

Sailsman63 · 2023-01-02T05:12:59Z

Would if be possible to add a short Javadoc comment explaining what/when this is used? IIUC, it's to allow lwjgl to render a scene to an AWT component, but lack of Javadoc is an ongoing pain-point for me with JME.

tonihele · 2023-01-08T11:35:54Z

Would if be possible to add a short Javadoc comment explaining what/when this is used? IIUC, it's to allow lwjgl to render a scene to an AWT component, but lack of Javadoc is an ongoing pain-point for me with JME.

The code is self-doc... :D As far as I know it is indeed used to render jME context inside an AWT component. Would that itself be a suffice explanation?

Sailsman63 · 2023-01-16T06:32:10Z

Sorry, I thought I had responded. Yeah, Just a one-liner stating the use. Most of the methods seem to be @Overrides anyway, so they are presumably documented further up the tree.

I am wondering if drawFrameInThread() and destroyFrameBuffer() are intended to be called from user code, or if they are marked public to allow some of the existing machinery to trigger them. If the later, a doc-comment warning that they should not be called directly might be in order.

tonihele added 8 commits November 20, 2022 21:56

Fix offscreen rendering by not triggering unnecessary resize

df08599

Not title

027ed6c

Better javadoc

e9ddcee

Modernize the code a bit

8ad6f99

Modernize the code a bit

4d31ae0

Don't init GLWF controllers (same as LWJGL 2)

bb4f4f3

Finals and interfaces

70aad8e

Java2D graphics based offscreen rendering Canvas solution

22380ab

tonihele commented Nov 21, 2022

View reviewed changes

Import desktop

c4b3b15

Ali-RS added this to the v3.6.0 milestone Jan 10, 2023

Ali-RS modified the milestones: v3.6.0, Future Release Jan 24, 2023

JNightRider mentioned this pull request Nov 29, 2023

LwjglCanvas using lwjgl-jawt #2153

Merged

scenemax3d modified the milestones: Future Release, v3.7.0 Jan 12, 2024

scenemax3d merged commit ec9c8c5 into jMonkeyEngine:master Jan 19, 2024

tonihele deleted the Lwjgl3Canvas branch January 19, 2024 09:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lwjgl3 canvas #1868

Lwjgl3 canvas #1868

tonihele commented Nov 21, 2022 •

edited

Loading

tonihele Nov 21, 2022

Ali-RS Feb 12, 2023 •

edited

Loading

Ali-RS Feb 12, 2023 •

edited

Loading

riccardobl commented Nov 22, 2022

tonihele commented Nov 22, 2022

riccardobl commented Nov 22, 2022

tonihele commented Nov 22, 2022 •

edited

Loading

Ali-RS commented Dec 31, 2022

tonihele commented Dec 31, 2022

Sailsman63 commented Jan 2, 2023

tonihele commented Jan 8, 2023

Sailsman63 commented Jan 16, 2023

Lwjgl3 canvas #1868

Lwjgl3 canvas #1868

Conversation

tonihele commented Nov 21, 2022 • edited Loading

tonihele Nov 21, 2022

Choose a reason for hiding this comment

Ali-RS Feb 12, 2023 • edited Loading

Choose a reason for hiding this comment

Ali-RS Feb 12, 2023 • edited Loading

Choose a reason for hiding this comment

riccardobl commented Nov 22, 2022

tonihele commented Nov 22, 2022

riccardobl commented Nov 22, 2022

tonihele commented Nov 22, 2022 • edited Loading

Ali-RS commented Dec 31, 2022

tonihele commented Dec 31, 2022

Sailsman63 commented Jan 2, 2023

tonihele commented Jan 8, 2023

Sailsman63 commented Jan 16, 2023

tonihele commented Nov 21, 2022 •

edited

Loading

Ali-RS Feb 12, 2023 •

edited

Loading

Ali-RS Feb 12, 2023 •

edited

Loading

tonihele commented Nov 22, 2022 •

edited

Loading