Skip to content

Write unit tests #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ixaxaar opened this issue Oct 29, 2017 · 4 comments
Closed

Write unit tests #8

ixaxaar opened this issue Oct 29, 2017 · 4 comments
Assignees
@ixaxaar
Labels
testing

Comments

@ixaxaar
Copy link
Owner

ixaxaar commented Oct 29, 2017

No description provided.

@ixaxaar ixaxaar self-assigned this Oct 29, 2017
@MaxwellRebo
Copy link
Contributor

What kinds of unit tests were you thinking? And which testing framework (if any)?

@MaxwellRebo
Copy link
Contributor

Just saw the commit. Answers my question. 😄

@ixaxaar
Copy link
Owner Author

ixaxaar commented Oct 29, 2017

@MaxwellRebo right now, I just wrote some quick ones which check if the output, hidden etc dimensions are correct

@ixaxaar
Copy link
Owner Author

ixaxaar commented Oct 29, 2017

I find myself making too many changes as this is still a quite initial phase, I'd want stuff to not break outright. Also integrating travis helps encourage write more detailed tests later on.

ixaxaar added a commit that referenced this issue Dec 10, 2017
@ixaxaar
Fixes #8
73b95eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ixaxaar ixaxaar

Labels
testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ixaxaar @MaxwellRebo