Skip to content

Fix crash on Python 3.8 or lower #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix crash on Python 3.8 or lower #24

wants to merge 1 commit into from

Conversation

lucastnr
Copy link

This fixes #23.

I had to fix two things:

  1. Tuple typing is not available on Python <= 3.8
  2. get_version can return a tuple with None, but it was not included in the typing

@lucastnr
fix: Import tuple from typing and fix typing error
3f27f51 
This fixes the script for Python <= 3.8
@lucastnr lucastnr changed the title fix: Import tuple from typing and fix typing error Fix crash on Python 3.8 or lower Apr 17, 2025
@lucastnr lucastnr mentioned this pull request Apr 17, 2025
Open
@lucastnr
Copy link
Author

lucastnr commented Apr 17, 2025 •
edited
Loading

I've created #25 (suggestion 1) and #24 (suggestion 2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash on Python <= 3.8
1 participant
@lucastnr