Open
Description
Context
In zmscitizenapi/src/Zmscitizenapi/Services/Core/MapperService.php
, the thinnedProcessToProcess()
method currently creates an anonymous stdClass
instance for the queue property:
$processEntity->queue = new \stdClass();
$processEntity->queue->status = $thinnedProcess->status;
Using stdClass
makes type safety and future evolution harder.
We should check whether a dedicated queue entity/value-object already exists in the domain model (e.g. Queue
, ProcessQueue
, etc.) and, if so, refactor the code to use it.
Tasks
- Search the codebase for queue-related classes that could replace
stdClass
. - Evaluate suitability (properties, constructor, usage elsewhere).
- If a suitable class exists, refactor
MapperService::thinnedProcessToProcess()
to use it. - If none exists, consider designing and introducing a typed queue class.
References
- PR fix(ZMSKVR-403): missing service name and address in delete mail #1106: fix(ZMSKVR-403): missing service name and address in delete mail #1106
- Comment: fix(ZMSKVR-403): missing service name and address in delete mail #1106 (comment)
/cc @ThomasAFink