Common casr tool #259

hkctkuy · 2025-05-10T15:15:53Z

Nobody wanted it, nobody asked it, but we did it anyway.

codecov · 2025-05-10T15:32:36Z

Codecov Report

Attention: Patch coverage is 81.25561% with 209 lines in your changes missing coverage. Please review.

Project coverage is 64.47%. Comparing base (4bc482c) to head (1a92ab2).
Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
casr/src/common.rs	77.09%	82 Missing ⚠️
libcasr/src/go.rs	13.33%	26 Missing ⚠️
libcasr/src/rust.rs	13.33%	26 Missing ⚠️
casr/src/stub.rs	0.00%	19 Missing ⚠️
casr/src/run.rs	87.61%	13 Missing ⚠️
libcasr/src/asan.rs	86.30%	10 Missing ⚠️
libcasr/src/python.rs	85.00%	9 Missing ⚠️
libcasr/src/msan.rs	87.50%	5 Missing ⚠️
casr/src/bin/casr.rs	97.43%	4 Missing ⚠️
libcasr/src/java.rs	92.10%	3 Missing ⚠️
... and 11 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
- Coverage   66.64%   64.47%   -2.17%     
==========================================
  Files          34       39       +5     
  Lines        8266     7629     -637     
==========================================
- Hits         5509     4919     -590     
+ Misses       2757     2710      -47

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

SweetVishnya · 2025-05-27T13:23:37Z

casr/tests/tests.rs

-    let output = Command::new(EXE_CASR_SAN)
-        .args(["--stdout", "--", &paths[1]])
+    let output = Command::new(EXE_CASR)
+        .args(["asan", "--stdout", "--", &paths[1]])


AFAIR, casr-san handles all sanitizers (e.g., msan). Maybe, we should rename casr asan to casr san?

Yes, there is san mod for backward capability with bahaviour that is equal to casr-san, asan and msan modes are needed for explicit indication for the parser when we are confident in it and do not want to try to guess it. The equal case for go and rust

SweetVishnya · 2025-05-27T13:25:29Z

libcasr/src/gdb/report.rs

@@ -0,0 +1,121 @@
+//! Gdb module implements `ParseStacktrace`, `Exception` and `Severity` traits for Gdb output.


These docs should be updated, I suppose

SweetVishnya · 2025-05-27T13:26:27Z

libcasr/src/gdb/report.rs

+    maps: Vec<String>,
+    report: Vec<String>,
+    stream: String,
+    stacktrace: Option<Stacktrace>,


Please, add docs to all fields

SweetVishnya · 2025-05-27T13:28:44Z

libcasr/src/gdb/report.rs

+};
+use regex::Regex;
+/// Structure provides an interface for save parsing gdb crash.
+pub struct GdbCrash {


We'd better call it GdbCrashReport or GdbCrashInfo

SweetVishnya · 2025-05-27T13:33:12Z

libcasr/src/gdb/report.rs

+            return Err(Error::Casr("Unable to get results from gdb".to_string()));
+        };
+        let stream = String::from_utf8_lossy(&stream);
+        let stream = stream.to_string();


do we actually need this to_string?

SweetVishnya · 2025-05-27T13:35:14Z

libcasr/src/gdb/report.rs

+    }
+    /// Get disassembly
+    pub fn disassembly(&self) -> &str {
+        &self.report[5]


Shouldn't we add it to GdbContext? I'm not sure by the way...

How does a lib user know, that the disassmebly is inside someRandomField[someRandomNumber]?

SweetVishnya · 2025-05-27T13:37:28Z

libcasr/src/asan.rs

+/// Structure provides an interface for save parsing some sanitizer crash.
+#[derive(Clone, Debug)]
+pub struct SanCrash {
+    context: StacktraceContext,


this is just a duplicate of StacktraceContext, do we need a new structure here? Or we can just create an alias?

SweetVishnya · 2025-05-27T13:38:44Z

libcasr/src/asan.rs

+
+impl AsanCrash {
+    /// Create new `AsanCrash` instance from stream
+    pub fn new(stream: &str) -> Result<Option<Self>> {


btw, we need some library tests for newly added functions.

SweetVishnya · 2025-05-27T13:39:22Z

libcasr/src/csharp.rs

@@ -116,7 +120,24 @@ impl ParseStacktrace for CSharpStacktrace {
 }

 /// Structure provides an interface for parsing c# exception message.
-pub struct CSharpException;
+pub struct CSharpException {
+    context: StacktraceContext,


the same here, mostly looks like a duplicate structure

SweetVishnya · 2025-05-27T13:51:24Z

libcasr/src/java.rs

@@ -20,7 +22,7 @@ impl ParseStacktrace for JavaStacktrace {
            conv_counter: usize,
        }
        // Get java stack trace.
-        let re = Regex::new(r"(?m)^(?:Caused by:|Exception in thread|== Java Exception:)(?:.|\n)*?((?:\n\s+at .*\(.*\))+)(?:\n\s+\.\.\. (\d+) more)?").unwrap();
+        let re = Regex::new(r"(?m)^(?:Caused by:|Exception in thread|== Java Exception:)(?:.|\n)*?((?:\n\s*at .*\(.*\))+)(?:\n\s*\.\.\. (\d+) more)?").unwrap();


Can we upstream first this change in a separate PR?

SweetVishnya · 2025-05-27T13:55:28Z

libcasr/src/python.rs

+
+impl PythonException {
+    /// Create new `PythonException` instance from Python output
+    fn new_from_python(stream: &str) -> Result<Option<Self>> {


we can just call it from_python

SweetVishnya · 2025-05-27T14:01:03Z

casr/src/util.rs

+    let sub = matches.subcommand();
+    for arg in args {
+        if !matches.contains_id(arg) && (sub.is_none() || !sub.unwrap().1.contains_id(arg)) {
+            bail!("The following argument is required: {}", arg);


Is this the same message as clap throws?

SweetVishnya · 2025-05-27T14:02:27Z

casr/src/triage.rs

-        casr_cmd.envs(&self.envs);
-
-        // Add envs
-        if self.target_args.iter().any(|x| x.eq("-detect_leaks=0")) {


Why do we remove this code?

We dоn't, just move it to the upper function

SweetVishnya · 2025-05-27T14:06:00Z

casr/src/mode.rs

+impl fmt::Display for Mode {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        let s = match self {
+            Mode::Csharp => "csharp",


we can store string mapping for enum somewhere, so, we don't repeate the same string constants

This function is a reverse function of new()

This is more optimal way then searching in map

SweetVishnya · 2025-05-27T14:06:54Z

casr/src/run.rs

+use goblin::container::Endian;
+use goblin::elf::{Elf, header};
+
+pub fn gdb_run(


Maybe, some of the code here can be moved to libcasr

SweetVishnya · 2025-05-27T14:08:56Z

casr/src/common.rs

+    Ok(())
+}
+
+pub fn prepare_run(argv: &mut [String], mode: &Mode) -> Result<()> {


Can we reduce copy-paste here? So, adding new cast tools could be easier

hkctkuy added 3 commits May 10, 2025 17:44

Make common casr tool draft

1ea2eab

Add enum

4da5148

Move func to a separate module

2163dde

hkctkuy requested a review from SweetVishnya May 10, 2025 15:15

hkctkuy marked this pull request as draft May 10, 2025 15:16

hkctkuy added 10 commits May 10, 2025 20:34

Upd tests

5a46938

Add msan support

53da8e5

Add go support

a09be0a

Add rust support

808ba5d

Add required args validation

69d25a7

Optimize lua parsing

8fa2870

Add StacktraceContext generic

18ba400

Add python support

d2ac110

Remove redundant methods

9933f4e

Fix stub path

09c8408

hkctkuy force-pushed the casr-common branch from d86809d to 09c8408 Compare May 12, 2025 21:36

hkctkuy added 4 commits May 13, 2025 19:54

Add stub

bf2c938

Add csharp support

d4e7aee

Add js support

cd99b3f

Add java support

5197e94

hkctkuy force-pushed the casr-common branch from fc47da6 to 5197e94 Compare May 15, 2025 19:12

hkctkuy added 4 commits May 16, 2025 20:39

Add gdb and signal support

05504e4

Add runners

83ae897

Fix exception checking

92a2586

Minor API changes

1a92ab2

hkctkuy force-pushed the casr-common branch from c6e0e4c to 1a92ab2 Compare May 17, 2025 14:06

hkctkuy added 3 commits May 17, 2025 19:53

Fix gdb feature

898fbab

Update casr-libfuzzer/casr-afl

12e766d

Func movement

0c2d4b4

Type rename

24724a6

SweetVishnya reviewed May 27, 2025

View reviewed changes

		@@ -0,0 +1,121 @@
		//! Gdb module implements `ParseStacktrace`, `Exception` and `Severity` traits for Gdb output.

Common casr tool #259

Are you sure you want to change the base?

Common casr tool #259

Uh oh!

Conversation

hkctkuy commented May 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented May 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hkctkuy May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hkctkuy May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hkctkuy commented May 10, 2025 •

edited

Loading

codecov bot commented May 10, 2025 •

edited

Loading

hkctkuy May 27, 2025 •

edited

Loading

hkctkuy May 27, 2025 •

edited

Loading