Fix product Standard::getVariantIds() #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
markom-werbeagentur
commented
Nov 29, 2024
markom-werbeagentur
commented
- Fix Product::getVariantIds() not working for variants with guests property #2551 (line 264)
- Fix product variants with guests=1 having protected property not being visible for logged in members having a matching group (line 303)
- Fix runtime error when a protected product variant having guests=1 for guest users (line 308)
…dardgetVariantIds() Fix product class standard::getVariantIds()
aschempp
approved these changes
Dec 3, 2024
aschempp
pushed a commit
that referenced
this pull request
Dec 3, 2024
|
Thank you @markom-werbeagentur! |
|
Thanks for the implementation :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.