Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of array_insert function (Adaption to Contao5 Step 005) #2494

Merged
merged 5 commits into from
Oct 17, 2023
Merged

Get rid of array_insert function (Adaption to Contao5 Step 005) #2494

merged 5 commits into from
Oct 17, 2023

Conversation

Ernestopheles
Copy link
Contributor

Next adaption towards Contao 5.

See useCases tested with cypress: tests
Contao 4.13.31, Isotope 2.9 and PHP 8.1

@Ernestopheles Ernestopheles changed the title C4 005 Adaption towards Contao5 Get rid of array_insert function (Adaption to Contao5 Step 005) Oct 15, 2023
@Ernestopheles
Copy link
Contributor Author

Next adaption (005) towards Contao 5.

Deprecated PHP function array_insert replaced by Contao\ArrayUtil::arrayInsert() method

See useCases tested with cypress: tests
Contao 4.13.31, Isotope 2.9 and PHP 8.1

Copy link
Member

@aschempp aschempp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will obvioiusly raise the minimum dependency of Isotope 2.9 to Contao 4.13, but I think this is a step we have to take to be able to update our code for Contao 5. Just one minor change request here.

@aschempp aschempp merged commit c57dda6 into isotope:2.9 Oct 17, 2023
@aschempp
Copy link
Member

Thank you @Ernestopheles

@aschempp aschempp added this to the 2.9.0 milestone Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants