-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use {{request_token}}
insert tag
#2339
Conversation
I did not yet fixed |
Isotope (currently) still supports Contao 4.9, so we have to continue to use its features even if they are deprecated. But thanks for the PR, this will give us a head-start once we can fix this 😊 |
This change does not conflict with Contao 4.9. Did you try it on Isotope Demo? |
The request token insert tag should not produce a wrong value, that would be a bug in Contao. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that the changes lgtm and should be compatible with Contao 4.9 anyway.
I think I meant that I was getting "CSRF token is invalid" message all the time. The value is not necessarily wrong. |
But if that happens only with the insert tag, it would still be a bug somewhere? Changing it to the service should make no difference. |
TBH I cannot reproduce it now either. May be the reason lied elsewhere, and I got A LOT fixed and updated in my Isotope app since this was opened. So probably you can disregard |
@ameotoko could we rebase this to 2.9 and use the |
0661f32
to
f8ad9af
Compare
Thank you @ameotoko |
{{request_token}}
insert tag is deprecated in Contao 4.13 and produces wrong value.