Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use {{request_token}} insert tag #2339

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

ameotoko
Copy link
Contributor

{{request_token}} insert tag is deprecated in Contao 4.13 and produces wrong value.

@ameotoko
Copy link
Contributor Author

I did not yet fixed iso_collection_default.html5 and iso_collection_favorites.html5 because I'm not sure which class is responsible for it.

@aschempp
Copy link
Member

Isotope (currently) still supports Contao 4.9, so we have to continue to use its features even if they are deprecated. But thanks for the PR, this will give us a head-start once we can fix this 😊

@ameotoko
Copy link
Contributor Author

This change does not conflict with Contao 4.9. Did you try it on Isotope Demo?

@fritzmg
Copy link
Contributor

fritzmg commented Jan 11, 2023

and produces wrong value.

The request token insert tag should not produce a wrong value, that would be a bug in Contao.

Copy link
Contributor

@fritzmg fritzmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that the changes lgtm and should be compatible with Contao 4.9 anyway.

@ameotoko
Copy link
Contributor Author

The request token insert tag should not produce a wrong value, that would be a bug in Contao.

I think I meant that I was getting "CSRF token is invalid" message all the time. The value is not necessarily wrong.

@fritzmg
Copy link
Contributor

fritzmg commented Jan 11, 2023

But if that happens only with the insert tag, it would still be a bug somewhere? Changing it to the service should make no difference.

@ameotoko
Copy link
Contributor Author

TBH I cannot reproduce it now either. May be the reason lied elsewhere, and I got A LOT fixed and updated in my Isotope app since this was opened. So probably you can disregard produces wrong value remark, but since the insert tag is deprecated anyway, merging this would still be a move forward, WDYT?

@aschempp aschempp added this to the 2.9.0 milestone Oct 16, 2023
@aschempp
Copy link
Member

@ameotoko could we rebase this to 2.9 and use the getDefaultTokenValue then?

@aschempp aschempp changed the base branch from 2.8 to 2.9 November 22, 2023 07:43
@aschempp aschempp merged commit 13017e1 into isotope:2.9 Nov 22, 2023
@aschempp
Copy link
Member

Thank you @ameotoko

@ameotoko ameotoko deleted the fix/requesttoken branch April 15, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants