implemented stream pause/resume #180
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@isaacs are you going to merge this? |
|
This would be great. Any problems with PR? |
|
Would be very useful when processing large XML files in GUI app. Having this function would allow pausing the stream, update the UI, and resume. Especially important on mobile, with React Native. |
|
NO PATCHES WITHOUT A TEST TEST MUST PASS WITH THE PATCH. TEST MUST FAIL WITHOUT THE PATCH. NO EXCEPTIONS. So... where’s the tes case? |
|
This is a dead repo. Why would he bother adding tests when it's never going to be merged? |
|
If interested then I’m sure @isaacs might accept you as an owner/contributor . I never saw that request... don’t be shy guys. |
Cactusbone
force-pushed
the
pause-resume
branch
from
b3f255f to
263276a
Compare
Streams starting with node 0.10 are expected to implement the stream.pause method See https://nodejs.org/api/stream.html#stream_compatibility_with_older_node_js_versions
Cactusbone
force-pushed
the
pause-resume
branch
from
263276a to
34d2bdf
Compare
|
@isaacs are you looking for help maintaining this module? |
|
Please add this :) @isaacs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stream can now be paused (i was getting an oom with a huge xml file, when i was not processing fast enough)