Skip to content

fix typos #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix typos #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions client/acme.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ func WithUserEmail(email string) P2PForgeCertMgrOptions {
}
}

// WithForgeAuth sets optional secret be sent with requests to the forge
// WithForgeAuth sets optional secret to be sent with requests to the forge
// registration endpoint.
func WithForgeAuth(forgeAuth string) P2PForgeCertMgrOptions {
return func(config *P2PForgeCertMgrConfig) error {
Expand Down Expand Up @@ -436,15 +436,15 @@ func (m *P2PForgeCertMgr) Start() error {
log.Infof("no cert found for %q", name)
}

// Start immediatelly if either:
// Start immediately if either:
// (A) preexisting certificate is found in certmagic storage
// (B) allowPrivateForgeAddresses flag is set
if certExists || m.allowPrivateForgeAddresses {
startCertManagement()
} else {
// No preexisting cert found.
// We will get a new one, but don't want to ask for one
// if our node is not publicly diallable.
// if our node is not publicly dialable.
// To avoid ERROR(s) in log and unnecessary retries we wait for libp2p
// confirmation that node is publicly reachable before sending
// multiaddrs to p2p-forge's registration endpoint.
Expand All @@ -454,7 +454,7 @@ func (m *P2PForgeCertMgr) Start() error {
return nil
}

// withHostConnectivity executes callback func only after certain libp2p connectivity checks / criteria against passed host are fullfilled.
// withHostConnectivity executes callback func only after certain libp2p connectivity checks / criteria against passed host are fulfilled.
// It will also delay registration to ensure user-set registrationDelay is respected.
// The main purpose is to not bother CA ACME endpoint or p2p-forge registration endpoint if we know the peer is not
// ready to use TLS cert.
Expand Down Expand Up @@ -572,7 +572,7 @@ func (d *dns01P2PForgeSolver) Wait(ctx context.Context, challenge acme.Challenge
// Check if DNS-01 TXT record is correctly published by the p2p-forge
// backend. This step ensures we are good citizens: we don't want to move
// further and bother ACME endpoint with work if we are not confident
// DNS-01 chalelnge will be successful.
// DNS-01 challenge will be successful.
// We check fast, with backoff to avoid spamming DNS.
pollInterval := 1 * time.Second
maxPollInterval := 1 * time.Minute
Expand Down