Fix Typos #66
Open
Fix Typos #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cewood
requested changes
Apr 11, 2025
README.md
Outdated
| @@ -125,7 +125,7 @@ Prebuilt images for `main` and `staging` branches are provided at https://github | |||
| Docker image ships without `/p2p-forge/Corefile` and `/p2p-forge/zones`, and you need to pass your own: | |||
|
|
|||
| ```console | |||
| $ docker build -t p2p-forge . && docker run --rm -it --net=host -v ./Corefile:/p2p-forge/Corefile.example -v ./zones:/p2p-forge/zones p2p-forge -conf /p2p-forge/Corefile.example -dns.port 5353 | |||
| $ docker build -t p2p-forge. && docker run --rm -it --net=host -v ./Corefile:/p2p-forge/Corefile.example -v ./zones:/p2p-forge/zones p2p-forge -conf /p2p-forge/Corefile.example -dns.port 5353 | |||
There was a problem hiding this comment.
This is incorrect, the dot is a short notation for the current directory, this proposed change is faulty.
There was a problem hiding this comment.
Thanks for the feedback! I’ve fixed the issue regarding the dot notation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Typos