This repository was archived by the owner on Jun 29, 2022. It is now read-only.
DAG-CBOR: strictly only allow a single top-level CBOR object #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The streaming form of CBOR (3.1) may use back-to-back top-level objects, we rule this out as a valid form for DAG-CBOR and require a single, explicit top-level object Ref: dignifiedquire/borc#47 (comment)
rvagg
added a commit
to ipld/js-ipld-dag-cbor
that referenced
this pull request
Jun 11, 2020
The streaming form of CBOR (3.1) may use back-to-back top-level objects without an explicit container and borc will decode this without failure. `decodeFirst()` will only return the first of these but additional data may exist but be hidden. Ref: dignifiedquire/borc#47 (comment) Ref: ipld/specs#268
rvagg
added a commit
to ipld/js-ipld-dag-cbor
that referenced
this pull request
Jun 11, 2020
The streaming form of CBOR (3.1) may use back-to-back top-level objects without an explicit container and borc will decode this without failure. `decodeFirst()` will only return the first of these but additional data may exist but be hidden. Ref: dignifiedquire/borc#47 (comment) Ref: ipld/specs#268
rvagg
added a commit
to ipld/js-dag-cbor
that referenced
this pull request
Jun 11, 2020
The streaming form of CBOR (3.1) may use back-to-back top-level objects without an explicit container and borc will decode this without failure. `decodeFirst()` will only return the first of these but additional data may exist but be hidden. Ref: ipld/js-ipld-dag-cbor#130 Ref: dignifiedquire/borc#47 (comment) Ref: ipld/specs#268
This was referenced Jun 11, 2020
mikeal
approved these changes
Jun 11, 2020
ribasushi
approved these changes
Jun 11, 2020
vmx
approved these changes
Jun 12, 2020
vmx
pushed a commit
to ipld/js-ipld-dag-cbor
that referenced
this pull request
Jun 12, 2020
The streaming form of CBOR (3.1) may use back-to-back top-level objects without an explicit container and borc will decode this without failure. `decodeFirst()` will only return the first of these but additional data may exist but be hidden. Ref: dignifiedquire/borc#47 (comment) Ref: ipld/specs#268
rvagg
added a commit
to ipld/js-dag-cbor
that referenced
this pull request
Jun 16, 2020
The streaming form of CBOR (3.1) may use back-to-back top-level objects without an explicit container and borc will decode this without failure. `decodeFirst()` will only return the first of these but additional data may exist but be hidden. Ref: ipld/js-ipld-dag-cbor#130 Ref: dignifiedquire/borc#47 (comment) Ref: ipld/specs#268
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The streaming form of CBOR (3.1) may use back-to-back top-level objects, we should rule this out as a valid form for DAG-CBOR and require a single, explicit top-level object.
Ref: dignifiedquire/borc#47 (comment) (borc doesn't reject this form of data as it inherited from an implementation that handled streaming data and the looseness was left in).