commands.NewRequest() has unexported type in it's arguments #890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Im not sure whether or not we should just export it... @jbenet thoughts? |
| @@ -15,8 +15,6 @@ import ( | |||
| u "github.com/jbenet/go-ipfs/util" | |||
| ) | |||
|
|
|||
| type optMap map[string]interface{} | |||
There was a problem hiding this comment.
Let's export OptMap (it's nice small and adds some type safety)
|
one comment above |
cryptix
force-pushed
the
fix/cmdsNewRequest
branch
from
d50ab22 to
86b34a2
Compare
|
exported instead |
|
LGTM, RFM |
jbenet
added a commit
that referenced
this pull request
Mar 9, 2015
commands.NewRequest() has unexported type in it's arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to play with the daemons JSON API a little, so I hacked together a tiny example in go that just does the equivalent of
ipfs ls <hash>.I only hit a small problem: commands.NewRequest()'s 2nd argument is an unexported map type. This PR removes this. Alternatively we could export it but i don't see much use in that.