Ipns/trickle append #867
Merged
Ipns/trickle append #867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| func (n *UnixfsNode) NumChildren() int { | ||
| return n.ufmt.NumChildren() | ||
| } | ||
|
|
||
| func (n *UnixfsNode) GetChild(i int, ds dag.DAGService) (*UnixfsNode, error) { | ||
| nd, err := n.node.Links[i].GetNode(ds) |
There was a problem hiding this comment.
potential index out of range?
There was a problem hiding this comment.
Yeah, as with any array access. Bounds should be checked prior to this call.
There was a problem hiding this comment.
same question for sigh, github y u no refresh :)RemoveChild and RemoveBlockSize()
whyrusleeping
force-pushed
the
ipns/trickle-append
branch
from
f58c602 to
8eaf47b
Compare
|
|
||
| // VerifyTrickleDagStructure checks that the given dag matches exactly the trickle dag datastructure | ||
| // layout | ||
| func VerifyTrickleDagStructure(nd *dag.Node, ds dag.DAGService, direct int, layerRepeat int) error { |
There was a problem hiding this comment.
@jbenet I thought you might like this one
|
Some comments above to address, but otherwise LGTM |
whyrusleeping
force-pushed
the
ipns/trickle-append
branch
from
57fb018 to
e539024
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements an 'Append' function for adding data to an existing dag while keeping the structure. I also implement a validator function to ensure that the structure is what we expect.
This is PR number 3 of the ipns set