-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Spring clean #835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spring clean #835
Conversation
wasn't used by ipfs directly, only by two main packages of dependencies that we tracks github.com/h2so5/utp/benchmark/main.go github.com/jbenet/go-random/random/random.go
This way, the following tests can already used the newly build libraries and don't have to build them again.
shareness needs the go-random/random utility. Godep doesnt know that.
@cryptix does this race happen often now? did it get introduced? https://build.protocol-dev.com/job/race/17356/console |
Oh, Right.. I the tab where I wanted to create the separate issue somehow disappeared. Thank's for spotting that. Idk if it is new or not.. cc @whyrusleeping, is it? |
Ive never seen that race before. It might not be new, but I think the tests should be run a few more times. (file an issue for the race). If it doesnt show up in the next 5 or so runs, I say youre good. |
thank you @cryptix |
I want to get a chance to read this over before merging. If i forget, pester me. |
@whyrusleeping PTAL 😉 |
LGTM, kinda weird that theres no jenkins test... but its probably okay |
Yeah.. looks like I borked it. Ever since that one I didn't see runs on the other PRs I worked on. |
@cryptix ya blew it |
5a53706
to
3a7f3e2
Compare
Awesome, thanks @cryptix! super helpful |
I updated two of our dependencies (fsnotify, go-uuid) and made sure that go-humanize isn't removed on 'make vendor'. It is need by the sharness test to build the
go-random/random
utility. I added thesadhack
package underutil
to get there.Apart from that I made four small tweaks.
go build -i
inmake build
- speeds up followinggo tests
drasticallyPOut()
from pkgutil
go-logging
inunixfs/io/dagmodifier_test.go
in preparation of of replacinggo-logging
withlogrus
maybebtc
to brian's new account nameleft overs:
github.com/briantigerchow/inflect
(@briantigerchow pushed the missing commits)go.crypto/
imports togolang.org/x/crypto
, needs to go throughg.yxqyang.asia/jbenet/go-multihash
as well.