Skip to content

Spring clean #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 1, 2015
Merged

Spring clean #835

merged 12 commits into from
Mar 1, 2015

Conversation

cryptix
Copy link
Contributor

@cryptix cryptix commented Feb 27, 2015

I updated two of our dependencies (fsnotify, go-uuid) and made sure that go-humanize isn't removed on 'make vendor'. It is need by the sharness test to build the go-random/random utility. I added the sadhack package under util to get there.

Apart from that I made four small tweaks.

  • use go build -i in make build - speeds up following go tests drastically
  • remove the unused POut() from pkg util
  • removed the direct use of go-logging in unixfs/io/dagmodifier_test.go in preparation of of replacing go-logging with logrus
  • renamed the old imports of maybebtc to brian's new account name

left overs:

  • fix the broken import of github.com/briantigerchow/inflect (@briantigerchow pushed the missing commits)
  • move old go.crypto/ imports to golang.org/x/crypto, needs to go through github.com/jbenet/go-multihash as well.
  • move back to upstream logrus
  • move back to upstream inflect

wasn't used by ipfs directly, only by two main packages of dependencies that we tracks

github.com/h2so5/utp/benchmark/main.go
github.com/jbenet/go-random/random/random.go
This way, the following tests can already used the newly build libraries and don't have to build them again.
shareness needs the go-random/random utility. Godep doesnt know that.
@btc btc added the status/in-progress In progress label Feb 27, 2015
@jbenet
Copy link
Member

jbenet commented Feb 27, 2015

Great!

@jbenet
Copy link
Member

jbenet commented Feb 27, 2015

@cryptix does this race happen often now? did it get introduced? https://build.protocol-dev.com/job/race/17356/console

@cryptix
Copy link
Contributor Author

cryptix commented Feb 27, 2015

Oh, Right.. I the tab where I wanted to create the separate issue somehow disappeared. Thank's for spotting that.

Idk if it is new or not.. cc @whyrusleeping, is it?

@whyrusleeping
Copy link
Member

Ive never seen that race before. It might not be new, but I think the tests should be run a few more times. (file an issue for the race). If it doesnt show up in the next 5 or so runs, I say youre good.

@btc
Copy link
Contributor

btc commented Feb 27, 2015

thank you @cryptix

@whyrusleeping
Copy link
Member

I want to get a chance to read this over before merging. If i forget, pester me.

@cryptix
Copy link
Contributor Author

cryptix commented Mar 1, 2015

@whyrusleeping PTAL 😉

@whyrusleeping
Copy link
Member

LGTM, kinda weird that theres no jenkins test... but its probably okay

@cryptix
Copy link
Contributor Author

cryptix commented Mar 1, 2015

Yeah.. looks like I borked it. Ever since that one I didn't see runs on the other PRs I worked on.

@whyrusleeping
Copy link
Member

@cryptix ya blew it

@cryptix cryptix force-pushed the springClean branch 2 times, most recently from 5a53706 to 3a7f3e2 Compare March 1, 2015 02:56
jbenet added a commit that referenced this pull request Mar 1, 2015
@jbenet jbenet merged commit 3863ec3 into master Mar 1, 2015
@jbenet jbenet removed the status/in-progress In progress label Mar 1, 2015
@jbenet jbenet deleted the springClean branch March 1, 2015 12:46
@jbenet
Copy link
Member

jbenet commented Mar 1, 2015

Awesome, thanks @cryptix! super helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants