Skip to content

Cleanup tour #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2015
Merged

Cleanup tour #1294

merged 2 commits into from
May 29, 2015

Conversation

rht
Copy link
Contributor

@rht rht commented May 26, 2015

@jbenet jbenet added the backlog label May 26, 2015
Side effect: this makes 'tour' accessible through the HTTP API

return
}

fprintTourShow(&w, t)
res.SetOutput(bytes.NewReader(w.Bytes()))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a better way to link the io.Reader and io.Writer together without having to create a buffer? I tried io.Pipe but it didn't work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should just be able to do res.SetOutput(w) here

@whyrusleeping
Copy link
Member

👍 woo!

@jbenet
Copy link
Member

jbenet commented May 29, 2015

wonder if tour should be a standalone tool altogether, instead of tied in...

@wking
Copy link
Contributor

wking commented May 29, 2015

On Thu, May 28, 2015 at 11:24:03PM -0700, Juan Batiz-Benet wrote:

wonder if tour should be a standalone tool altogether, instead of
tied in...

Eventually, I'd like to see the tour and other docs just bundled into
an archive (1, #1195). Unpacking the docs to your local file system
and reading them with your pager/editor/browser seems like a better UI
than trying to write a file-browser command. But I don't have a
problem with folks polishing the existing tour command until we get
around to writing the archive tooling.

jbenet added a commit that referenced this pull request May 29, 2015
@jbenet jbenet merged commit ecdf149 into ipfs:master May 29, 2015
@jbenet jbenet removed the backlog label May 29, 2015
@whyrusleeping whyrusleeping mentioned this pull request Jun 1, 2015
49 tasks
@rht rht deleted the cleanup-tour branch June 2, 2015 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants