-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Cleanup tour #1294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup tour #1294
Conversation
Side effect: this makes 'tour' accessible through the HTTP API
|
||
return | ||
} | ||
|
||
fprintTourShow(&w, t) | ||
res.SetOutput(bytes.NewReader(w.Bytes())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a better way to link the io.Reader
and io.Writer
together without having to create a buffer? I tried io.Pipe
but it didn't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should just be able to do res.SetOutput(w)
here
👍 woo! |
wonder if tour should be a standalone tool altogether, instead of tied in... |
On Thu, May 28, 2015 at 11:24:03PM -0700, Juan Batiz-Benet wrote:
Eventually, I'd like to see the tour and other docs just bundled into |
#555