Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: Basic UnixFS sanity checks #10701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Basic UnixFS sanity checks #10701
Changes from 21 commits
f8a2fe5
9db46b1
3031cf3
b28bce9
e922ef0
3297308
4a8bb62
a687b2b
de94ec6
58e4c90
8e6796f
fa7c769
1296054
888e1e8
8ab8a83
d945049
34f05a2
b77142d
9f7f8b6
9a59b8d
7ad6847
548f630
5c93132
bf04ec1
23c8b6e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lidel
I noticed an interesting behavior here...
This test reveals something important about your implementation - the
--force flag
skips the initial validation, but there's still a later step (flushing) that can't handle non-UnixFS node types.filesCpCmd
allows copying anon-UnixFS node
with --force, but MFS itself might not be able to properly handle orflush
that type of node, causing this error during the flush operation.What should I do?? Maybe create another PR to handle the Flush thing....
Adding the
Flush
here will make this PR quite big ig.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed this during triage today, and the consensus is to remove
--force
flag.We don't have time to go intoo rabbit hole of fleshing out specs for MFS that supports codecs other than UnixfS( dag-pb and raw).
We don't want this actually, because MFS data model is files and directories (which could be mounted over something like FUSE in the future).
This formally limits
ipfs files
API to files and directories (unixfs).If someone wants to mix UnixFS with other codecs (like dag-cbor) they can use lower level API at
ipfs dag
.@PsychoPunkSage so the ask is to remove
--force
from this PR 🙏There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disregard, I'm going to do it :)