-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Closed
Labels
P2Medium: Good to have, but can wait until someone steps upMedium: Good to have, but can wait until someone steps upeffort/hoursEstimated to take one or several hoursEstimated to take one or several hoursexp/wizardExtensive knowledge (implications, ramifications) requiredExtensive knowledge (implications, ramifications) requiredkind/bugA bug in existing code (including security flaws)A bug in existing code (including security flaws)kind/discussionTopical discussion; usually not changes to codebaseTopical discussion; usually not changes to codebasetopic/commandsTopic commandsTopic commands
Description
Version information:
v0.5.1
Description:
ipfs id QmSelf
prints out:
{
"ID": "QmSelf",
"PublicKey": "...",
"Addresses": [
"/ip4/104.131.131.82/udp/4001/quic/p2p/QmSelf",
"/ip4/104.131.131.82/tcp/4001/p2p/QmSelf"
],
"AgentVersion": "go-ipfs/0.5.1/8431e2e",
"ProtocolVersion": "ipfs/0.1.0"
}
ipfs id QmOtherPeer
prints out:
{
"ID": "QmOtherPeer",
"PublicKey": "...",
"Addresses": [
"/ip4/104.131.131.82/udp/4001/quic", // note the lack of peer ID.
"/ip4/104.131.131.82/tcp/4001"
],
"AgentVersion": "go-ipfs/0.5.1/8431e2e",
"ProtocolVersion": "ipfs/0.1.0"
}
We should either drop the /p2p/...
part from ipfs id QmSelf
, or add it to ipfs id QmOtherPeer
. Unfortunately, both solutions are breaking. I'd prefer the first solution because the /p2p/Qm...
part is redundant. However, that option is also the more breaking option.
Metadata
Metadata
Assignees
Labels
P2Medium: Good to have, but can wait until someone steps upMedium: Good to have, but can wait until someone steps upeffort/hoursEstimated to take one or several hoursEstimated to take one or several hoursexp/wizardExtensive knowledge (implications, ramifications) requiredExtensive knowledge (implications, ramifications) requiredkind/bugA bug in existing code (including security flaws)A bug in existing code (including security flaws)kind/discussionTopical discussion; usually not changes to codebaseTopical discussion; usually not changes to codebasetopic/commandsTopic commandsTopic commands