Skip to content

fix(peer) derive public key from private key #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
btc opened this issue Oct 28, 2014 · 1 comment
Closed

fix(peer) derive public key from private key #220

btc opened this issue Oct 28, 2014 · 1 comment
Labels
help wanted Seeking public contribution on this issue

Comments

@btc
Copy link
Contributor

btc commented Oct 28, 2014

In WithKeyPair, public key is passed in with private key and then compared.

TODO simply derive public from private.

see 9ca87fb#commitcomment-8313740
@btc btc added the ready label Oct 28, 2014
@btc btc self-assigned this Oct 28, 2014
btc referenced this issue Oct 28, 2014
@jbenet
peer.Peer is now an interface
9ca87fb 
![](http://m.memegen.com/77n7dk.jpg)
@btc btc removed their assignment Oct 28, 2014
@btc btc added the help wanted Seeking public contribution on this issue label Oct 28, 2014
@btc btc removed the ready label Nov 24, 2014
@whyrusleeping
Copy link
Member

I think this one can be closed, we no longer use WithKeyPair

ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Oct 23, 2021
@vyzo
Merge pull request ipfs#220 from libp2p/gx/update
c3adc43 
gx publish 4.4.19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Seeking public contribution on this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@btc @whyrusleeping