fix: restore standalone js-ipld instance #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR partially reverts #287 because `/api/v0/dag` in go-ipfs do not implement latest IPLD features yet, and ipfs-http-client delegates path traversal and resolution to go-ipfs, so codecs in JS are never used. By reverting to standalone js-ipld we decouple IPLD explorer from what is available in go-ipfs – we simply fetch raw block and do all decoding the old way, in JS. We will revisit this in the future, after IPLD Prime work lands in go-ipfs, but for now this is the only way to fix IPLD Explorer to work against go-ipfs backend. License: MIT Signed-off-by: Marcin Rataj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially reverts #287 because
/api/v0/dagin go-ipfs do not implement latest IPLD features yet, and ipfs-http-client delegates path traversal and resolution to go-ipfs, so codecs in JS are never used, and what is in go-ipfs underdagcommands is not enough.By reverting to standalone js-ipld we decouple IPLD explorer from what is available in go-ipfs – we simply fetch raw block and do all decoding the old way, in JS.
We will revisit this in the future, after IPLD Prime work lands in go-ipfs, but for now this is the only way to fix IPLD Explorer to work against go-ipfs backend and correctly traverse dag-pb and dag-cbor