Skip to content

chore: Upgrade github.com/ipfs/go-ds-pebble to v0.5.1 for Go 1.25 support #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stefanb
Copy link

@stefanb stefanb commented Jun 29, 2025

Go 1.25 incompatibility detected in

then:

This PR brings just this upstream fix upstream to ipget by bubbling up through

Details:

Before:

go1.25rc1 build ./...
github.com/cockroachdb/swiss
# github.com/cockroachdb/swiss
github.com/cockroachdb/swiss
# github.com/cockroachdb/swiss
../../../go/pkg/mod/github.com/cockroachdb/[email protected]/map.go:286:7: undefined: hashFn
../../../go/pkg/mod/github.com/cockroachdb/[email protected]/map.go:337:14: undefined: getRuntimeHasher
../../../go/pkg/mod/github.com/cockroachdb/[email protected]/map.go:338:22: undefined: fastrand64
../../../go/pkg/mod/github.com/cockroachdb/[email protected]/map.go:600:23: undefined: fastrand64
../../../go/pkg/mod/github.com/cockroachdb/[email protected]/map.go:649:19: undefined: fastrand64
../../../go/pkg/mod/github.com/cockroachdb/[email protected]/map.go:670:20: undefined: fastrand64
../../../go/pkg/mod/github.com/cockroachdb/[email protected]/options.go:30:14: undefined: hashFn

After:

go1.25rc1 build ./...

(build successful)

Go 1.25 incompatibility detected in
* Homebrew/homebrew-core#226636

then:
* reported upstream in cockroachdb/swiss#48
* fixed upstream cockroachdb/swiss#49

This PR brings just this upstream fix upstream to ipfs.
Alternatively we could wait until
* ipfs/kubo#10850

is merged and released an then upgrade the `github.com/ipfs/kubo` direct dependancy.

---

Before:
go1.25rc1 build ./...
github.com/cockroachdb/swiss
# github.com/cockroachdb/swiss
../../../go/pkg/mod/github.com/cockroachdb/[email protected]/map.go:286:7: undefined: hashFn
../../../go/pkg/mod/github.com/cockroachdb/[email protected]/map.go:337:14: undefined: getRuntimeHasher
../../../go/pkg/mod/github.com/cockroachdb/[email protected]/map.go:338:22: undefined: fastrand64
../../../go/pkg/mod/github.com/cockroachdb/[email protected]/map.go:600:23: undefined: fastrand64
../../../go/pkg/mod/github.com/cockroachdb/[email protected]/map.go:649:19: undefined: fastrand64
../../../go/pkg/mod/github.com/cockroachdb/[email protected]/map.go:670:20: undefined: fastrand64
../../../go/pkg/mod/github.com/cockroachdb/[email protected]/options.go:30:14: undefined: hashFn

Upgrade:
go get -u github.com/cockroachdb/swiss && go mod tidy
go: upgraded github.com/cockroachdb/swiss v0.0.0-20250327203710-2932b022f6df => v0.0.0-20250624142022-d6e517c1d961

After:
go1.25rc1 build ./...
(build successful)
Copy link

welcome bot commented Jun 29, 2025

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

Copy link
Contributor

@gammazero gammazero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to use go-ds-pebble v0.5.1 or wait until kubo v0.36.0 is released and then depend on that.

@gammazero gammazero added the need/author-input Needs input from the original author label Jul 2, 2025
@stefanb stefanb changed the title chore: Upgrade github.com/cockroachdb/swiss for Go 1.25 support chore: Upgrade github.com/ipfs/go-ds-pebble to v0.5.1 for Go 1.25 support Jul 2, 2025
@stefanb stefanb requested a review from gammazero July 2, 2025 05:36
@stefanb
Copy link
Author

stefanb commented Jul 2, 2025

After merging please don't forget to make a release before or right after go 1.25 is released in August (rc2 is expected on tuesday, July 8th).

@gammazero
Copy link
Contributor

I would prefer to wait until the next kubo release to create a new release of ipget. That should be very soon.

@gammazero gammazero added status/deferred Conscious decision to pause or backlog and removed need/author-input Needs input from the original author labels Jul 8, 2025
@lidel
Copy link
Member

lidel commented Jul 8, 2025

Triage note:

  • Kubo 0.36.0-rc2 will ship later this week, final one expected to land next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/deferred Conscious decision to pause or backlog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants