-
Notifications
You must be signed in to change notification settings - Fork 514
feat: Add thumbnails support for files in grid view #2337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 28 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
f22d5a3
feat: Add grid view mode with thumbnails for files page
george-hub331 b490e6d
feat: Enhance files page with multi-select and keyboard navigation
george-hub331 47f641f
fix: Improve FilesGrid and GridFile styling and linting
george-hub331 4b76dde
feat: Improve file selection and view mode in Files Page
george-hub331 cbd4b03
feat: Add text preview for files in grid view
george-hub331 ba6383c
Merge branch 'main' into thumbnail-addition
george-hub331 8507e66
chore: remove yarn.lock file
george-hub331 1205468
feat: use larger icon size when preview is not available for grids
george-hub331 6021c9c
feat: Improve view mode UI and file hash display
george-hub331 b9f8de3
feat: Add view mode translations and adjust UI styling
george-hub331 f61bf3d
feat: Improve FilesGrid keyboard navigation and responsiveness
george-hub331 1fe9b1a
style: Reduce border width from 2px to 1px in default state
george-hub331 175630c
fix: resolve issue with storybook test
george-hub331 ca63ce4
feat: Add keyboard shortcuts and drag-and-drop support for gridfiles
george-hub331 0c4a5bc
Merge branch 'main' into thumbnail-addition
george-hub331 8df9581
fix: avoid jiggling ui
lidel 3deea61
fix: avoid changing unrelated translations
lidel 6430413
fix: remove shadow on hover
lidel ba6864c
Merge branch 'main' into thumbnail-addition
george-hub331 0acb827
chore: remove translation edits
SgtPooki cc3c47e
Merge branch 'main' into thumbnail-addition
SgtPooki 2ab0c2b
chore: rename shortcut model filename
SgtPooki 60b620a
chore: fix mem leak and side effects
SgtPooki 7beaa11
chore: rename new files to kebab case
SgtPooki 933a302
fix: grid keyboard nav
SgtPooki f1e29c8
fix: migrate to typescript
SgtPooki f9977b1
chore: fix lint failures
SgtPooki fe6e294
chore: fix runtime error
SgtPooki 05d7fbe
fix: simplify keyboard shortcut condition
george-hub331 48c97d3
fix: resolve issue with enter shortcut on grid
george-hub331 8c33280
chore: remove default props on FilesList
george-hub331 6272ea9
feat: add grid view step to files tour
george-hub331 03bfd01
fix: improve keyboard navigation and refactor grid file component
george-hub331 5a0a185
feat: add e2e tests for grid view functionality
george-hub331 a85f55b
chore: remove e2e unnecessary setup script
george-hub331 206215d
fix: resolve error with grid e2e tests
george-hub331 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
george-hub331 marked this conversation as resolved.
Show resolved
Hide resolved
george-hub331 marked this conversation as resolved.
Show resolved
Hide resolved
george-hub331 marked this conversation as resolved.
Show resolved
Hide resolved
george-hub331 marked this conversation as resolved.
Show resolved
Hide resolved
george-hub331 marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this fixes an issue where TS and webpack and eslint fought against each other about import extensions..
ideally all imports should end in file extension ".js"