Skip to content

Support new onboarding in Brave Nightly 1.23.22+ #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lidel opened this issue Mar 6, 2021 · 0 comments · Fixed by #984
Closed

Support new onboarding in Brave Nightly 1.23.22+ #982

lidel opened this issue Mar 6, 2021 · 0 comments · Fixed by #984
Assignees
@lidel
Labels
area/brave Issues related to Brave Browser effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP

Comments

@lidel
Copy link
Member

lidel commented Mar 6, 2021

In the past we opened ipfs://bafkreigxbf77se2an2u6hmg2kxxbhmenetc7dzvkd3rl4m2orlobjvqcqq and that triggered dropbar.

In brave-browser-nightly-1.23.22-linux-amd64 that dropbar is replaced with full page UI which after starting the node moves user back to ipfs://bafkreigxbf77se2an2u6hmg2kxxbhmenetc7dzvkd3rl4m2orlobjvqcqq/

Unfortunately it does not update state to ipfs://bafkreigxbf77se2an2u6hmg2kxxbhmenetc7dzvkd3rl4m2orlobjvqcqq/#done so user is left with awkward request.
@lidel lidel added kind/bug A bug in existing code (including security flaws) exp/novice Someone with a little familiarity can pick up exp/intermediate Prior experience is likely helpful P0 Critical: Tackled by core team ASAP area/brave Issues related to Brave Browser effort/hours Estimated to take one or several hours labels Mar 6, 2021
@lidel lidel self-assigned this Mar 6, 2021
lidel added a commit that referenced this issue Mar 10, 2021
@lidel
refactor: adjust Brave activation UI flow
07ed8b1 
- remove custom HTML UI (Brave 1.23.22+ provides own UI)
- use bafkqaaa as the trigger
- cleanup bafkqaaa, switch to Preferences/Welcome page
- single codebase, works in both old and new Brave

Closes #982
@lidel lidel mentioned this issue Mar 10, 2021
Merged
lidel added a commit that referenced this issue Mar 10, 2021
@lidel
refactor: adjust Brave activation UI flow
55c3f2e 
- remove custom HTML UI (Brave 1.23.22+ provides own UI)
- use bafkqaaa as the trigger
- cleanup bafkqaaa, switch to Preferences/Welcome page
- single codebase, works in both old and new Brave

Closes #982
lidel added a commit that referenced this issue Mar 10, 2021
@lidel
refactor: adjust Brave activation UI flow (#984)
77a88c4 
- remove custom HTML UI (Brave 1.23.22+ provides own UI)
- use bafkqaaa as the trigger
- cleanup bafkqaaa, switch to Preferences/Welcome page
- single codebase, works in both old and new Brave

Closes #982
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
area/brave Issues related to Brave Browser effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: adjust Brave activation UI flow ipfs/ipfs-companion
1 participant
@lidel