Adding a revert policy #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubuxu
reviewed
Sep 19, 2016
|
|
||
| When some change is introduced, and we decide that it isn't beneficial and/or it causes problems, we need to revert it. | ||
|
|
||
| To make the review process and the changes easier, use git's `revert` command to revert some changes. |
| To make the review process and the changes easier, use git's `revert` command to revert some changes. | ||
|
|
||
| This suits a few purposes. First, it is much easier to see if some change was reverted by just looking into the history of the file. Imagine a commit with the title: _Add feature C_. There are many ways one could form the title for a commit reverting it, but by using `git revert`, it will be _Revert: "Add feature C"_ and thus very clear. | ||
| Second, by using `git revert` we are sure that all changes were reverted. It is much easier to star again for state 0 and apply changes on it, than try to see if some transformation transforms state 1 to state 0. |
This comes directly from ipfs/kubo#3166, and @Kubuxu. I have added it here and edited it slightly for language.
RichardLitt
force-pushed
the
feat/add-revert-changes-section
branch
from
c5f135e to
ac0090b
Compare
|
@Kubuxu Approve changes? |
|
Yup LGTM. |
Kubuxu
approved these changes
Oct 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes directly from ipfs/kubo#3166, and @Kubuxu. I have added it here and edited it slightly for language.