Skip to content

provider: depuplicate cids in provider queue #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

guillaumemichel
Copy link
Contributor

Change the queue internal buffer from a Deque to a lru.Cache to deduplicate cids that are added to the provider queue.

@guillaumemichel guillaumemichel requested a review from a team as a code owner April 15, 2025 13:52
@guillaumemichel guillaumemichel force-pushed the dedpuplicate-provider-queue branch from 2f8289a to 23b728f Compare April 15, 2025 15:25
@guillaumemichel guillaumemichel marked this pull request as draft April 15, 2025 16:10
@guillaumemichel
Copy link
Contributor Author

LRU caches cannot be used as a drop in replacement for the internal buffer, since for the purpose of deduplication they should remember recent CIDs that aren't in the queue anymore.

Closing in favor of #910

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant