Refactor(hostname): Skip DNSLink for local IP addresses to avoid DNS queries #880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id unnecessary DNS queries Signed-off-by: gitsrc <[email protected]>
…id unnecessary DNS queries Signed-off-by: gitsrc <[email protected]>
gitsrc
changed the title
|
Turns out that we need to igore app IP addresses, not just localhost. |
gammazero
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the hostname handling logic to skip DNSLink lookups for IP addresses.
The hasDNSLinkRecord function now explicitly checks if the provided hostname is an IP address. If it is an IP address, the function immediately returns false, skipping the DNSLink lookup.
This change avoids unnecessary DNS queries when the hostname is an IP address. This improves efficiency and reduces potential delays, especially in local development environments where DNS lookups for IPs are not needed and can sometimes cause issues.
Closes #879