Skip to content
This repository was archived by the owner on Oct 30, 2023. It is now read-only.

feat: publish preview to IPFS on PR #256

Merged
merged 1 commit into from
Apr 29, 2019
Merged

feat: publish preview to IPFS on PR #256

merged 1 commit into from
Apr 29, 2019

Conversation

olizilla
Copy link
Contributor

  • move CI from jenkins to circle
  • use ipfs-dns-deploy to get an IPFS preview status link on PRs

License: MIT
Signed-off-by: Oli Evans [email protected]

- move CI from jenkins to circle
- use ipfs-dns-deploy to get an IPFS preview status link on PRs

License: MIT
Signed-off-by: Oli Evans <[email protected]>
@ghost ghost assigned olizilla Apr 18, 2019
@ghost ghost added the status/in-progress In progress label Apr 18, 2019
@olizilla
Copy link
Contributor Author

@PedroMiguelSS i'm seeing test failures when trying to push...

  Running: service-worker.js...  

  1) Service worker activates and then deactivates successfully:
     Uncaught SyntaxError: Unexpected token ...

@PedroMiguelSS
Copy link
Contributor

@alanshaw also mentioned it in #254. I did take a look at this and I found out that cypress has a problem when we use cypress run command. This command by default runs the tests headlessly in the Electron browser. Electron browser does not support es6 syntax.
We are currently using babel to transpile our src/ code but I think we must create a lighter babel config to transpile our node_modules/ code so that Electron does not complain about syntax errors like this one.
Alternatively, we can add --browser chrome to cy:run script. This will open chrome and run the tests automatically. However, this is can only be a temporary solution because when we pass the --browser argument it will attempt to launch the browser if detected on the machine. This is not ideal to run the tests automatically on the CI.

If you want to be sure that the tests are not failing you can run npm run test:e2e and it will open up Chrome and then you can run the tests manually.

I'll fix this, but I need to include this task on my sprint. I'm currently working on IDM project. We can discuss how important comparing to IDM tasks and include it on my sprint.

@PedroMiguelSS PedroMiguelSS merged commit 50f8ec7 into master Apr 29, 2019
@ghost ghost removed the status/in-progress In progress label Apr 29, 2019
@PedroMiguelSS PedroMiguelSS deleted the circleci branch April 29, 2019 23:08
PedroMiguelSS added a commit that referenced this pull request Apr 30, 2019
* chore: upgrade to js-ipfs 0.34 (#241)

The files API changed in 0.34 - this updates the site to use the new API. I've also separately updated the codepen examples.

resolves #232

License: MIT
Signed-off-by: Alan Shaw <[email protected]>

* chore(i18n): support pt_PT and pt_BR 

Context: ipfs-shipyard/i18n#7

* feat: publish preview to IPFS on PR (#256)

- move CI from jenkins to circle
- use ipfs-dns-deploy to get an IPFS preview status link on PRs

License: MIT
Signed-off-by: Oli Evans <[email protected]>

* chore: upgrade to js-ipfs 0.35 (#254)

* chore: upgrade to js-ipfs 0.35

Static types and utils exports moved to package level in 0.35.

See https://blog.ipfs.io/80-js-ipfs-0-35/#api-changes

I will also update the CodePen examples.

License: MIT
Signed-off-by: Alan Shaw <[email protected]>

* chore: upgrate service-worker-gateway to 0.1.13

* chore: update multiple deps

* feat: include ipfs-camp ribbon (#255)

* chore: update translation files (#257)

* chore: update translation files
* chore: remove duplicated info from readme

* chore: update website hash (#258)

* chore: remove unused dev domain from CI (#260)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants