This repository was archived by the owner on May 20, 2025. It is now read-only.

fix(indexer)!: add indexed id to fix implicit aliases and nfts #1075

Merged

DaughterOfMars merged 13 commits into main from fix/indexer/ids

Feb 1, 2023

Collaborator

DaughterOfMars commented Jan 27, 2023 •

edited by Alex6323

Loading

Linked Issues

Closes Outputs with implicit alias and NFT ids are not indexed correctly #1074

Notes to Reviewer

As a reviewer, please pay particular attention to the following areas when reviewing this PR and tick the above boxes after you have completed the steps.

API Changes

Test the indexer API endpoints.

INX Changes

Run chronicle using an INX connection.

Database Changes

Review database queries for correctness/conciseness.
Ensure queries are supported by indexes if needed.
Check for breaking changes in the data model and matching (conventional) commit message prefix.
Run the migration script.


          Add indexed id to fix implicit aliases and nfts. Add migration binary.

7b1aa9d

DaughterOfMars requested review from grtlr and Alex6323

January 27, 2023 17:08


          Merge branch 'main' into fix/indexer/ids

a3a50d7

grtlr reviewed

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

grtlr reviewed

View reviewed changes

src/migrations/1.0.0-beta.31.rs Outdated Show resolved Hide resolved

grtlr reviewed

View reviewed changes

src/migrations/1.0.0-beta.31.rs Outdated Show resolved Hide resolved

grtlr reviewed

View reviewed changes

src/migrations/1.0.0-beta.31.rs Outdated Show resolved Hide resolved

grtlr reviewed

View reviewed changes

src/db/collections/outputs/indexer/mod.rs Outdated Show resolved Hide resolved

Alex6323 reviewed

View reviewed changes

src/migrations/1.0.0-beta.31.rs Outdated Show resolved Hide resolved

Alex Coats added 5 commits

January 30, 2023 09:16


          Move migrations to a CLI command

fa2e915


          Merge branch 'fix/indexer/ids' of https://github.com/iotaledger/inx-c…

c723259

…hronicle into fix/indexer/ids


          Check for indexed id kind

40baaf6


          Merge branch 'main' into fix/indexer/ids

5f3bd68


          Make crypto dep mandatory

185945f

grtlr previously approved these changes

View reviewed changes

Contributor

grtlr left a comment •

edited

Loading

Thanks for adding the additional changes. LGTM, but still needs testing.


          Small fix

99d826c

Alex6323 dismissed grtlr’s stale review via

99d826c

January 31, 2023 11:45


          Mongo doesn't want to hear that it has to match

843e511

Alex6323 reviewed

View reviewed changes

src/bin/inx-chronicle/migrations/migrate_1_0_0_beta_31.rs Show resolved Hide resolved

Alex6323 reviewed

View reviewed changes

src/bin/inx-chronicle/migrations/migrate_1_0_0_beta_31.rs Show resolved Hide resolved

Alex Coats added 2 commits

January 31, 2023 08:53


          Use pipeline for update many

5d5af27


          Merge branch 'fix/indexer/ids' of https://github.com/iotaledger/inx-c…

821ea8f

…hronicle into fix/indexer/ids

DaughterOfMars mentioned this pull request

Outputs with implicit alias and NFT ids are not indexed correctly #1074

Closed

grtlr reviewed

View reviewed changes

src/bin/inx-chronicle/migrations/migrate_1_0_0_beta_31.rs Show resolved Hide resolved


          Merge branch 'main' into fix/indexer/ids

grtlr previously approved these changes

View reviewed changes


          Fix details level

323c697

DaughterOfMars dismissed grtlr’s stale review via

323c697

February 1, 2023 14:44

Alex6323 approved these changes

View reviewed changes

grtlr approved these changes

View reviewed changes

DaughterOfMars merged commit c37a5cb into main

DaughterOfMars deleted the fix/indexer/ids branch

February 1, 2023 15:51

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet