Skip to content

Provide default fileNesting patterns #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2023

Conversation

MangelMaxime
Copy link
Contributor

Fix #1724

Adding the configuration like done in this PR seems to be enough to have nesting pattern added for F#.

This configuration is merged with the default configuration from VSCode:

image

The picture above is the result of doing Fable.Core.JS.console.log (Configuration.getUnsafe "explorer.fileNesting.patterns") when loading Ionide.

However, the drawback I see is that if the user don't want the nested feature for F# files and he try to set its configuration then the default value completed doesn't contain the default configuration from VSCode but only the ones from Ionide.

Screen.Recording.2023-03-11.at.22.31.54.mov

Personally, I think this is problem in VSCode and not in Ionide.

If we want, to preserve the defaults configuration then, we would need to do something similar to Suggest gitignore:

  • Ask the user if he wants F# nesting patterns.
  • If yes
    • Retrieve the current nesting patterns settings
    • Merge with F# nesting patterns and save in the workspace settings
  • If no, discard or save user choice to not suggest again

Copy link
Contributor

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this :)

@baronfel baronfel merged commit 6589dcc into ionide:main Mar 11, 2023
@MangelMaxime
Copy link
Contributor Author

Always happy to help :)

Doing a tour of the issues I can fix in Ionide.

@MangelMaxime MangelMaxime deleted the feature/nesting_pattern branch March 11, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide default settings for VSCode Explorer File Nesting feature
2 participants