Provide default fileNesting patterns #1846
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1724
Adding the configuration like done in this PR seems to be enough to have nesting pattern added for F#.
This configuration is merged with the default configuration from VSCode:
The picture above is the result of doing
Fable.Core.JS.console.log (Configuration.getUnsafe "explorer.fileNesting.patterns")
when loading Ionide.However, the drawback I see is that if the user don't want the nested feature for F# files and he try to set its configuration then the default value completed doesn't contain the default configuration from VSCode but only the ones from Ionide.
Screen.Recording.2023-03-11.at.22.31.54.mov
Personally, I think this is problem in VSCode and not in Ionide.
If we want, to preserve the defaults configuration then, we would need to do something similar to Suggest gitignore: