Skip to content

fix(refresher): quickly swiping down no longer causes duplicate refresh #25476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #25418

See #25418 (comment) for explanation of why this happens

What is the new behavior?

  • Reset this.progress to 0 in the onStart callback. This is the same as what the non-native refreshers do.
  • This uncovered another issue where quickly swiping to complete caused an error because we were not disabling the gesture correctly. I changed this to always disable the gesture in onEnd and then have each animation re-enable the gesture (the snapback animations)

Does this introduce a breaking change?

  • Yes
  • No

Other information

Note: This fix cannot be tested reliably on CI because it requires swiping quickly which cannot be guaranteed on CI.

@github-actions github-actions bot added the package: core @ionic/core package label Jun 15, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review June 15, 2022 15:32
@liamdebeasi liamdebeasi requested a review from a team June 15, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: refresher, quickly scrolling after cancelling refresh causes duplicate refresh
2 participants