chore(cli): Deprecate cordova.staticPlugins #7564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested review from
andredestro,
markemer,
EiyuuZack,
theproducer and
nflsilva
andredestro
approved these changes
Jul 16, 2024
markemer
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cordova.staticPluginsis used to put some plugins into a separate CocoaPods project that hasstatic_framework = true.This is used in some plugins that use
frameworktag for CocoaPods, which didn't allow to specify if they need to be static.But using
frameworktag for CocoaPods dependencies is not supported on latest cordova-ios (version 7.x that was released a year ago).So if Cordova doesn't support that, we shouldn't have this special case for plugins that are out of date.
If they are up to date, using
podspectag instead offrameworktag, then they can specify if the plugin needs to be static or not and Capacitor already handles that.Also note that we have a list of plugins that we knew that needed to be static so users didn't have to add them with this configuration and we haven't updated the list for 3 years, so probably nobody is needing it anymore.