Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxonomy #7833

Merged
merged 6 commits into from
Mar 26, 2025
Merged

Taxonomy #7833

merged 6 commits into from
Mar 26, 2025

Conversation

jazzhaiku
Copy link
Collaborator

@jazzhaiku jazzhaiku commented Mar 25, 2025

Summary

This PR moves type definitions out of config.py into a new taxonomy.py module.
The goal is to reduce clutter in config.py, and to resolve circular import issues by isolating these types in a dedicated module with (almost) no internal dependencies.
Because so many places import these definitions, these changes touch 73 files.

Additional changes:

  • Removed star imports using "removestar" tool
  • Added the commit to .git-blame-ignore-revs to avoid noise in git blame history

Related Issues / Discussions

QA Instructions

Merge Plan

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added api python PRs that change python files Root invocations PRs that change invocations backend PRs that change backend files services PRs that change app services python-tests PRs that change python tests labels Mar 25, 2025
@jazzhaiku jazzhaiku marked this pull request as ready for review March 26, 2025 02:07
Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

We have a number of places where were import modules dynamically - for example, when using if TYPE_CHECKING: or in certain functions.

I'm not confident in the IDE's ability handle these imports, so I searched the codebase for instances of such dynamic imports (^[ \t]+(?:import|from).* over *.py files).

All looks good - there are only a couple places where these dynamic imports were importing taxonomy stuff anyways.

@jazzhaiku jazzhaiku enabled auto-merge March 26, 2025 04:09
@jazzhaiku jazzhaiku merged commit 35222a8 into main Mar 26, 2025
15 checks passed
@jazzhaiku jazzhaiku deleted the taxonomy branch March 26, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api backend PRs that change backend files invocations PRs that change invocations python PRs that change python files python-tests PRs that change python tests Root services PRs that change app services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants