feat(nodes): clean up lora node names #7824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
brandonrising,
hipsterusername and
jazzhaiku
as code owners
github-actions
bot
added
python
blessedcoolant
approved these changes
Mar 23, 2025
hipsterusername
approved these changes
Mar 24, 2025
I had named them wonkily and caused some user confusion.
psychedelicious
force-pushed
the
psyche/feat/nodes/lora-node-names
branch
from
706ae0a to
ea09f0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I had named them wonkily and caused some user confusion.
Here are all the new names
Related Issues / Discussions
Wonky names introduced in #7795
QA Instructions
Are the names OK?
Merge Plan
n/a
Checklist
What's Newcopy (if doing a release after this PR)