feat(ui): custom dropdowns for strings in builder #7818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
hipsterusername
approved these changes
Mar 21, 2025
Accidentally removed it
…anging component to a different type
Non-functional naming change to clarify the logic
psychedelicious
force-pushed
the
psyche/feat/ui/workflow-builder-dropdowns
branch
from
1490578 to
03a0506
Compare
|
I've fixed a couple minor issues and cleaned up the code. I tried to find a way to generalize this to be extended to other field types (e.g. floats, integers, models) and other UI widgets (e.g. radio options), but I don't think there's a good way to do it without compromising runtime and compile-time type safety. There is too much variation between field types. So other field types will need their own implementations for both logic and UI. Technically, implementing other field types is pretty straightforward, but figuring out a reasonable UX may be challenging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for custom dropdowns for string fields in Builder. Workflow Builders can choose this for the string component and add options to it.
Screen.Recording.2025-03-21.at.6.08.08.pm.mov
Related Issues / Discussions
n/a
QA Instructions
Try it out.
Merge Plan
n/a
Checklist
What's Newcopy (if doing a release after this PR)