Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port LLaVA to new API #7817

Merged
merged 8 commits into from
Mar 24, 2025
Merged

Port LLaVA to new API #7817

merged 8 commits into from
Mar 24, 2025

Conversation

jazzhaiku
Copy link
Collaborator

@jazzhaiku jazzhaiku commented Mar 21, 2025 •
edited
Loading

Summary

  • Port LLaVA model config to new classification API
  • Add 2 test cases (stripped LLaVA models variants to git-lfs)

Related Issues / Discussions

QA Instructions

Merge Plan

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added python PRs that change python files backend PRs that change backend files python-tests PRs that change python tests labels Mar 21, 2025
@jazzhaiku jazzhaiku marked this pull request as ready for review March 21, 2025 07:04
psychedelicious
psychedelicious approved these changes Mar 24, 2025
View reviewed changes
Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I successfully tested two scenarios:

  • Installing the model from the model manager's starter models tab (which provides some field overrides)
  • Installing the model from disk (which provides no overrides and is therefore a more complete test of probing logic)

@jazzhaiku jazzhaiku enabled auto-merge March 24, 2025 04:17
@jazzhaiku jazzhaiku merged commit ed9efe7 into main Mar 24, 2025
15 checks passed
@jazzhaiku jazzhaiku deleted the llava branch March 24, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychedelicious psychedelicious psychedelicious approved these changes

@hipsterusername hipsterusername hipsterusername approved these changes

@lstein lstein Awaiting requested review from lstein lstein is a code owner

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@brandonrising brandonrising Awaiting requested review from brandonrising brandonrising is a code owner

Assignees
No one assigned
Labels
backend PRs that change backend files python PRs that change python files python-tests PRs that change python tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jazzhaiku @psychedelicious @hipsterusername